search

vegastrike / Assets-Masters

Vega Strike Upon The Coldest Sea Original Game Data Art Sources (e.g. hi-poly/hi-res source models/images)
8 stars 6 forks source link

Release tar ball missing programs #29

Closed susnux closed 3 years ago

susnux commented 3 years ago

Describe the bug The programs directory is missing in the tar.xz release tar ball. ( vsUTCS_v0.7.0-Source.tar.xz )

BenjamenMeyer commented 3 years ago

@susnux please be more specific in your bug. Are you looking for the generated binaries to also be provided?

BenjamenMeyer commented 3 years ago

Looking closer...https://github.com/vegastrike/Assets-Production/blob/master/CMakeLists.txt#L66 should make it be included, though I can see with tar -Jtx that programs isn't in there. Not sure why...probably due to the types of files in there.

susnux commented 3 years ago

@susnux please be more specific in your bug. Are you looking for the generated binaries to also be provided?

Yes, sorry. The tar.xz tar ball provided on GitHub (releases) does not contain the programs directory, so building will fail as CMake can not find that directory.

Loki1950 commented 3 years ago

What do you mean by a programs directory I have been with this project for over ten years there has never been a directory called programs there is one called /bin where the executable and .dll's on windows are placed.

BenjamenMeyer commented 3 years ago

@Loki1950 https://github.com/vegastrike/Assets-Production/tree/master/programs Probably need to call it shaders instead.

Loki1950 commented 3 years ago

Ah that one forget why klauss called it programs so yes shaders would more descriptive.

stephengtuggy commented 3 years ago

I would like to see this get fixed in 0.7.x, as well as in 0.8.x and on master. I don't think it will be too difficult a fix. In fact, I'll take a look at it right now.

BenjamenMeyer commented 3 years ago

@stephengtuggy for 0.7.x leave it as programs; for 0.8.x or 0.9.x we'll rename it to shaders.

stephengtuggy commented 3 years ago

@BenjamenMeyer Sounds good.

stephengtuggy commented 3 years ago

@susnux could you verify whether or not this problem is fixed as of https://github.com/vegastrike/Assets-Production/releases/tag/v0.7.1-beta1 ?

BenjamenMeyer commented 3 years ago

Added #31 to track the rename separately. This can be closed out once someone (preferably @susnux ) confirms that the latest releases fix this.

pyramid3d commented 3 years ago

As far as I recall, the programs directory was introduced by former contributor klauss during his planetary shader improvements stanza. https://github.com/vegastrike/Assets-Production/tree/master/programs seems to contain the shader programs but I do not have any insight as to how those tie into the code as those changes happened during my hiatus from the project. If you really need to track it back the old svn repo should still have the history available.

susnux commented 3 years ago

@susnux could you verify whether or not this problem is fixed as of https://github.com/vegastrike/Assets-Production/releases/tag/v0.7.1-beta1 ?

It works as expected :+1: