search

vegastrike / Assets-Masters

Vega Strike Upon The Coldest Sea Original Game Data Art Sources (e.g. hi-poly/hi-res source models/images)
8 stars 6 forks source link

weapons.json is not being installed #43

Closed evertvorster closed 5 months ago

evertvorster commented 2 years ago

This is a new file, and it's not included in the CMakelists.txt

Without it, the game crashes hard on startup.

Attached is a zipped file of the patch to get it to install.

weapons_fix.zip

stephengtuggy commented 2 years ago

Does this change really need to be made in 0.8.x? Or just in 0.9.x/master?

evertvorster commented 2 years ago

If 0.8.x will ever get the engine interpreting json, then it needs it.

As far as I am aware that was not in the plans, and releases are only supposed to get bug fixes?

Kind regards, Evert Vorster Awesome Chapters Tours http://www.awesomechapters.com Tel: +264 (0) 811477690

On Wed, 8 Jun 2022 at 21:08, Stephen G Tuggy @.***> wrote:

Does this change really need to be made in 0.8.x? Or just in 0.9.x/master?

— Reply to this email directly, view it on GitHub https://github.com/vegastrike/Assets-Masters/issues/43#issuecomment-1150292448, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC34XVL7MVZN5DBPTNTK7WLVODVSZANCNFSM5X6VK4NQ . You are receiving this because you authored the thread.Message ID: @.***>

BenjamenMeyer commented 2 years ago

no, we're not back porting it to 0.8.x. 0.8.x is what is it; though we'll fix bugs there if they come up. @evertvorster the Arch stuff only pulls master, right? The question came up b/c of a bug report from an Arch user IIRC. (#697)

evertvorster commented 2 years ago

There are four arch packages, a set of engine and assets that pull master, and then a set that pulls the latest release.

But if the latest release will not get the json interpreting engine, then it does not need the patch. In fact, I think the patch will break install as it will look for a file that does not exist in that branch.

On Fri, Jun 10, 2022, 04:52 Benjamen Meyer @.***> wrote:

no, we're not back porting it to 0.8.x. 0.8.x is what is it; though we'll fix bugs there if they come up. @evertvorster https://github.com/evertvorster the Arch stuff only pulls master, right? The question came up b/c of a bug report from an Arch user IIRC.

— Reply to this email directly, view it on GitHub https://github.com/vegastrike/Assets-Masters/issues/43#issuecomment-1151868107, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC34XVNVGC246KRANBUHK23VOKUVJANCNFSM5X6VK4NQ . You are receiving this because you were mentioned.Message ID: @.***>

stephengtuggy commented 2 years ago

Can this issue be closed? I.e., is it fixed?

stephengtuggy commented 5 months ago

I'm closing this ticket. I'm quite certain that it is fixed.