vegastrike / Assets-Production

Vega Strike - Upon The Coldest Sea Game Data in Engine-Consumable Form
https://www.vega-strike.org
GNU General Public License v2.0
26 stars 15 forks source link

Stars, planets and installations orbiting inside the radius of their parent body #102

Open Eribotes opened 1 year ago

Eribotes commented 1 year ago

I found that the preconfigured Sol/Alpha_Centauri.system file in vegastrike/sectors/Sol/ has a couple of objects orbiting inside the radius of their parent body, preventing access to them.

The planet Hart is a child planet of the planet Holman, which has a radius of 3500000, but the orbital parameters for Hart specify ri="15000" sj="18000". I changed them to an arbitrary ri="4500000" sj="4800000" which made the planet accessible.

The second star ProximaCentuari, which although not a child of the primary star, Alpha_Centauri A, nevertheless appeared to be located inside it (rj="200000" sk="200000") and changing those values to an arbitrary rj="20000000000" sk="20000000000" made it and its child planet Schultz accessible . Although not defined as a child of Alpha_Centauri A I found I also needed to increase their year values as they were now travelling too fast through space to match velocities, which implies they were actually orbiting Alpha_Centauri A as though they were children of it. I changed the year value for ProximaCentuari from 30000 to 2000000 and the year value for Schultz from 7000 to 40000. Both of those values were arrived at by progressively increasing the year value for them until the relative speed between each one and a stationary ship was reasonable i.e. below a few hundred.

The planet Hart also had a malformed closing xml tag "<\lanet>" instead of "<\Planet>".

Eribotes commented 1 year ago

With hindsight, I think this issue should have probably been posted against the Assets-Production repository.

Can it be moved or should I re-file it?

BenjamenMeyer commented 1 year ago

@Eribotes thanks; yes I'll move it over for you. Can you please file a PR?