search

vegastrike / Assets-Production

Vega Strike - Upon The Coldest Sea Game Data in Engine-Consumable Form
https://www.vega-strike.org
GNU General Public License v2.0
26 stars 15 forks source link

bases/main_menu.py: Bump version in intro title and credits title to 0.7 #38

Closed stephengtuggy closed 4 years ago

stephengtuggy commented 4 years ago

The 0.6.2 version of vsUTCS still says 0.5.2 alpha in these two places. Oops!

Updating master to reflect version 0.7.0. We may want to update the 0.6.x branch as well.

royfalk commented 4 years ago

At work, the way we avoid issues like this is by having the CICD plug in the value from the branch name. Something to consider.

BenjamenMeyer commented 4 years ago

@royfalk its mixed. There's a few solutions methods; I haven't found a good one yet. Using branch/tag names makes it hard to use 0.6.x as the branch as x isn't valid in the numeric field, meaning we're also having to make a lot more branches.

Other solutions use environment variables, or specialized packages. Honestly I haven't seen a good one. We can certainly explore options in an Issue though.

Loki1950 commented 4 years ago

What about adding a check and verify step to the release routine for now so we at least don't get to embarrassed in the future.

BenjamenMeyer commented 4 years ago

For my Python projects I usually add something to the unit tests to make sure things match up (typically b/c it's specified in multiple places)... not sure how we can do that here or if that would apply.

Opened https://github.com/vegastrike/Assets-Masters/issues/19 to continue the discussion.