Open BenjamenMeyer opened 3 years ago
This is happening because of the CMakeLists.txt clause SET(CPACK_PACKAGE_DESCRIPTION_FILE "${CMAKE_CURRENT_SOURCE_DIR}/../README.md")
. Instead of setting the package description from a file, I think we should just set it directly as a text value. That is what I have done in my PR, as follows:
SET(CPACK_PACKAGE_NAME "Vega-Strike")
SET(CPACK_PACKAGE_DESCRIPTION_SUMMARY "3D OpenGL spaceflight simulator")
SET(CPACK_PACKAGE_DESCRIPTION "Vega Strike 3D OpenGL spaceflight simulator (game engine)")
SET(CPACK_PACKAGE_VENDOR "Vega Strike")
#SET(CPACK_PACKAGE_DESCRIPTION_FILE "${CMAKE_CURRENT_SOURCE_DIR}/../README.md")
CPACK_PACKAGE_DESCRIPTION
takes the place of CPACK_PACKAGE_DESCRIPTION_FILE
. The new description is much shorter, too, like I think it should be. Open to discussion though.
I don't mind the long description, we just need to have it formatted properly for the files. Using a tool to convert is fine to do that, we'd just have to write a CMake step that would generate the temp file with the contents
We can do it in steps if needed too.
CLoneWolf from the forums suggested escaping the [
and seeing if that works as he ran into a similar issue with something else and PyCharm. That might alleviate the README.md side; but we'd still need something to generate the shorter description that is showing up as HTML.
WE're good for 0.7.x. Anything more can be in 0.8.x or 0.9.x
We need to fix the one for the Assets too.
I believe this is fixed for 0.8.x, as of #626
@stephengtuggy feel free to cut v0.8.0 Alpha 1 to check
I loaded up the 0.7.0-alpha4 release (and checked against 0.7.0-alpha3 too) and the description changed from the 0.6.0 release in both a good and bad way. Good in that it's actually descriptive now; bad in that the formatting fails after a point.
It seems to be a mix of HTML and MarkDown formatted as plain text, and after a point the MarkDown fails and just explodes into an incomprehensible blob (see below).
The following should be likely be done:
This might all be doable by running a converter to HTML and sending the converted output the packager instead of the source files.
The below is what I see from the QApt Package Installer GUI used in KDE.