search

vegastrike / Vega-Strike-Engine-Source

Vega Strike Engine
Other
258 stars 43 forks source link

Log entries need module id included #674

Open LifWirser opened 2 years ago

LifWirser commented 2 years ago

Upon reviewing logfiles I generated , I noticed while there are many errors there is no where msg came from.

stephengtuggy commented 2 years ago

I'm thinking that we could add function scope to the Boost logging to solve this.

BenjamenMeyer commented 2 years ago

don't have a log to reference so we might have some already, but we should verify that we have:

Objects (classes, structures) should also log a unique ID of some sort (address?).

stephengtuggy commented 2 years ago

I'm not sure if we can easily get all of those, but we can at least get file, line, and function

BenjamenMeyer commented 2 years ago

@stephengtuggy let's get what we can

LifWirser commented 2 years ago

On 0.8.x and using "--debug =3" option is much better (giving too much info now). . Question where to put the output? @BenjamenMeyer I found most if not all of them in 0.8.x From what I now see the is lots of work - repeats possible. It even gave me a leak report after^-c ( anotherhang). btw I made sure I called bash before cmkae (I don't think it had an effect- whoknows)

LifWirser commented 2 years ago

umm This is embarassing. I installed valgrind and unknown to me it set itself up in the VSE when I compiled/ran it this time (0.8.x). So still lots of leak data - just not from VSE as I originally thought.

BenjamenMeyer commented 1 year ago

Let's just focus on the log message formatting here per https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/674#issuecomment-1139677381