search

vegastrike / Vega-Strike-Engine-Source

Vega Strike Engine
Other
258 stars 43 forks source link

Source download of release 0.8.0 is broken #696

Open VorpalBlade opened 2 years ago

VorpalBlade commented 2 years ago

If I download https://github.com/vegastrike/Vega-Strike-Engine-Source/releases/download/v0.8.0/Vega-Strike_v0.8.0-Source.tar.xz (linked from https://github.com/vegastrike/Vega-Strike-Engine-Source/releases/tag/v0.8.0) it appears that this is just the "engine" subdirectory of the git repo. This doesn't work properly as the CMakeLists.txt in engine refers to ../doc, leading to a CMake error:

CMake Error at CMakeLists.txt:1336 (ADD_SUBDIRECTORY):
  ADD_SUBDIRECTORY given source "../doc" which is not an existing directory.

Presumably either the packaging scripts or the CMakeLists.txt need to be fixed.

BenjamenMeyer commented 2 years ago

@VorpalBlade thanks for reporting. The doc directory is suppose to be getting included in that. It's definitely a packaging error.

LifWirser commented 2 years ago

my first question where was cmake started compared to VSE tree? Was it in a }VSE_root|/build ".cmake ../engine" or how?

VorpalBlade commented 2 years ago

my first question where was cmake started compared to VSE tree? Was it in a }VSE_root|/build ".cmake ../engine" or how?

That doesn't really matter if you check the tarball I linked to. Because it only contains the engine directory. The doc directory would be one above the root of the archive. So it can never work.

BenjamenMeyer commented 2 years ago

@VorpalBlade try the files provided by GitHub while we look into why https://github.com/vegastrike/Vega-Strike-Engine-Source/blob/master/engine/CMakeLists.txt#L1270 isn't working to get it in there.

BenjamenMeyer commented 9 months ago

Can confirm. @VorpalBlade sorry for the delay; yes the XZ file is incomplete. We'll try to fix that in a future release. In the mean time, pleasee use https://github.com/vegastrike/Vega-Strike-Engine-Source/archive/refs/tags/v0.8.0.zip or https://github.com/vegastrike/Vega-Strike-Engine-Source/archive/refs/tags/v0.8.0.tar.gz. We'll try to get it right for the upcoming 0.9.x release.

NOTE: 0.8.x might see another minor release before 0.9.x gets done; but this probably won't be fixed for it. Will see what we can do though.