search

vegastrike / Vega-Strike-Engine-Source

Vega Strike Engine
Other
255 stars 44 forks source link

v0.8.0 crashes on entering Sol system #759

Open Samweis2111 opened 1 year ago

Samweis2111 commented 1 year ago

Whenever I try to enter Sol:Sol the game crashes. The last lines of output are:

libpng warning: Interlace handling should be turned on when using png_read_image terminate called after throwing an instance of 'std::invalid_argument' what(): stod /usr/bin/vs: line 28: 64293 Aborted vegastrike -d"${VEGASTRIKE_SHARE_DIR}" "$1"

Eribotes commented 1 year ago

I hit this problem on Debian 11 and after a bit of searching I figured that 'stod' was probably a string-to-double function and was receiving bad input values, hence the 'invalid_argument'. Looking at the xml definition for the Sol system (/usr/share/vegastrike/sectors/Sol/Sol.system) I found that the 'si' values for the four starfortresses and the Mars Commerce Centre were all set to "" i.e. 'si=""'. Changing these items to 'si="0"' stopped the crashes.

Samweis2111 commented 1 year ago

'stod' was probably a string-to-double function

Well spotted! I can confirm that this solves the issue.

BenjamenMeyer commented 1 year ago

@Eribotes awesome find. Are you able to provide a PR to help fix that? Probably against the Assets Production repository.

evertvorster commented 2 months ago

This is a big issue in the 0.8.x engine, it simply refuses to load Sol, crashing on loading the moon texture. The 0.9.x engine loads Sol just fine