search

vegastrike / Vega-Strike-Engine-Source

Vega Strike Engine
Other
252 stars 44 forks source link

0.9.x Updates 2024-04-18 to 04-22 by SGT #846

Closed stephengtuggy closed 2 months ago

stephengtuggy commented 2 months ago

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues: Fixes #844 for 0.9.x Attempts to fix #837 for 0.9.x

Purpose:

stephengtuggy commented 2 months ago

a few comments to keep in mind; but generally looking good

@BenjamenMeyer thanks.

stephengtuggy commented 2 months ago

Well, that last commit was a winner lol.

With regard to the logging system: A few days ago, I thought I would try switching to asynchronous logging, to see if that increased performance. Well, maybe it did and maybe it didn't. But what I primarily noticed was that the last message logged before program shutdown, never made it to the console. No matter what I tried.

So I am switching back to synchronous sinks. Maybe I'll try the async version again some other time.

stephengtuggy commented 2 months ago

Also: Rocky Linux 8.9 keeps throwing one error after another. I think I'm going to allow it to fail for now. And maybe stop building it at all in the CI, until further notice.

stephengtuggy commented 2 months ago

Also: Rocky Linux 8.9 keeps throwing one error after another. I think I'm going to allow it to fail for now. And maybe stop building it at all in the CI, until further notice.

Done ✔️

stephengtuggy commented 2 months ago

I have switched back to using synchronous logging sinks. The logging system seems to be working again, more or less as before.

stephengtuggy commented 2 months ago

... And #837 is not fixed. Damn. Oh well, I need to get this merged to fix the other issue (#844 ).

I'm going to go ahead and merge.