Lib Component - Improvements to Resource

vegastrike / Vega-Strike-Engine-Source

Vega Strike Engine

Other

252 stars 44 forks source link

Lib Component - Improvements to Resource #852

Closed royfalk closed 2 months ago

royfalk commented 2 months ago

This is part of the lib component PRs. Various bug fixes and additions to Resource class. Add unit tests

Please answer the following:

Code Changes:

[X] Have the PR Validation Tests been run? See https://github.com/vegastrike/Vega-Strike-Engine-Source/wiki/Pull-Request-Validation. Also wrote unit tests.
[ ] This is a documentation change only

Issues:

Loaded game had the ship constantly flying to the right.

stephengtuggy commented 2 months ago

Um, the issue with the ship constantly flying to the right sounds like a big deal to me. Can we get that fixed before we merge this?

I'm very glad you are adding more unit tests. We could certainly use more of those.

royfalk commented 2 months ago

Um, the issue with the ship constantly flying to the right sounds like a big deal to me. Can we get that fixed before we merge this? I've seen this bug before. That's definitely not something related to the Resource class. The save game in general is buggy as hell. When you load a game from another game, you don't find yourself in dock but in space. This will need a real deep dive into the system.

From the looks of it, it's now failing with: Could NOT find Python3 (missing: Python3_INCLUDE_DIRS Python3_LIBRARIES. in Rocky Linux 8.7. Can I merge?

stephengtuggy commented 2 months ago

Um, the issue with the ship constantly flying to the right sounds like a big deal to me. Can we get that fixed before we merge this? I've seen this bug before. That's definitely not something related to the Resource class. The save game in general is buggy as hell. When you load a game from another game, you don't find yourself in dock but in space. This will need a real deep dive into the system.

From the looks of it, it's now failing with: Could NOT find Python3 (missing: Python3_INCLUDE_DIRS Python3_LIBRARIES. in Rocky Linux 8.7. Can I merge?

The Rocky Linux 8.7 failure is not a blocker. Our code in general doesn't build on Rocky Linux 8.x anymore We're not going to support it any longer.

I would like to play test this a little bit before we merge, if you don't mind.

royfalk commented 2 months ago

I would like to play test this a little bit before we merge, if you don't mind. Be my guest.

stephengtuggy commented 2 months ago

The one issue I did encounter was with the autopilot overshooting my destination, a medical station -- over and over and over. I don't think that's a new issue, but it might be. We'll probably want to troubleshoot that later.