search

vegastrike / Vega-Strike-Engine-Source

Vega Strike Engine
Other
256 stars 42 forks source link

Training mission not accepting maximum speed #861

Open evertvorster opened 3 months ago

evertvorster commented 3 months ago

When doing the training mission with Oswald, it never gets past the "Set your speed to maximum" bit.

I first thought that it is because the ship does not get to its actual maximum speed, as the initial ship you are kitted out with needs a refuel and repair before it gets to its rated 125. I do remember that this ship in its original trim and maximum speed of 120 would get through this part of the training in previous versions of the game.

VegaStrike and the VegaStrike engine were compiled from sources pulled from git master on 2024-06-11. I added in my high resolution backgrounds, and modified the screen resolutions to work on my setup.

Apart from that, it is a fresh install, and a new game that was started to get to the training mission.

On a side note, I am planning on doing a few Youtube videos where you can see these bugs in action. This bug was hit by the first video to be made, and I'll post the link here once the video is live.

evertvorster commented 3 months ago

Here is a link to the video on Youtube: https://youtu.be/8gm58jOCbMc

evertvorster commented 3 months ago

Looking at this issue a little more too. In the training mission, Oswald asks you to increase your speed to maximum. Your craft right at the beginning has a max speed of 120. I can get this part of the training mission to pass by pressing Y, then backspace again. This time, the maximum speed is 120000. As my speed increases, somewhere around 300 that part of the mission turns bright green and moves on to the next step.

It would appear that the training mission is reading the wrong values for the ship I am in.

Further correlation is that he asks you to set a negative speed of -20 later on. This speed is impossible to set in the Llama, as it's theoretical max backward speed is 10% of it's forward speed, ie: -12. Again it is possible to pass this part of the training mission by switching GCNT into TRAVEL mode by pressing Y, and increasing the backwards thrust.

As far as I can tell with this testing, it would appear that Oswald thinks my ship is capable of 200 forward and -20 backwards in GCNT:MANEUVER, but where is he getting those values from?

BenjamenMeyer commented 1 month ago

@royfalk seems like something with the new Ship data loading.

@evertvorster does it still happen if you use the old CSV files? IIRC the engine should still read either the CSV or JSON files. Would be nice to know if its just the JSON side or if its both.

royfalk commented 3 weeks ago

This may have something to do with the physics model in settings. I remember playing the game around 2006-2010 and seeing the Llama speeds jump by a multiplier of 2 or 3. The quest file is modules/quest_tutorial.py Line 455 if (angle>=0.20 and velocity>=295): So something changed at some point.

evertvorster commented 3 weeks ago

So, it is hard coded? Hmm. It should read the maximum speed of the ship you are in. Of course that would be the Llama with its top speed of 120 (125 after being refueled and fixed the first time)