search

vegawidget / altair

R interface to 'Altair'
https://vegawidget.github.io/altair
Other
91 stars 9 forks source link

Add note on how to use JSON backend #129

Closed andyreagan closed 3 years ago

ijlyttle commented 3 years ago

Hi @andyreagan,

Thanks for the PR, and for kicking off the discussion at htmlwidgets. I finally was able to get together some time to look at this properly.

When I started digging into this, I thought it would be straightforward. Ha! I ended up making some changes at vegawidget, but the big effect is to issue a warning if you try to knit using a data-dependency.

FWIW, I found out that the data-dependency technique works only interactively. As well, if you want to get around calling vegawidget() explicitly, you can set an option.

I reworked the PR to take these into account - if these aren't OK with you, let me know and we can make additional changes.

andyreagan commented 3 years ago

Hey @ijlyttle,

Thanks for taking the time to dig into this and add to the documentation. The changes look great to me! Glad to see this incorporated.