search

veged / coa

Command-Option-Argument: Get more from defining your command line interface
MIT License
144 stars 22 forks source link

Make npm package lighter #88

Closed holtjohnson closed 7 years ago

holtjohnson commented 7 years ago

Thanks for your work, I use your package via NPM for a lot of my projects! Thought I'd contribute some and help lighten the package for production environments. 😄

http://samt.us/what-goes-in-npmignore/ https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 7c9b4a92c92bbc9607601713068b6e2bd2787957 on holtjohnson:patch-1 into on veged:master.

qfox commented 7 years ago

Heya!

Don't get why npm should bundle test, tests into package. There is "files" option in package.json with lib directory only: https://github.com/veged/coa/blob/master/package.json#L14-L18

Are you sure we still need .npmignore?

holtjohnson commented 7 years ago

We don't! Sorry I didn't check for the "files" option being used in package.json. I knew the npm package had just been updated 17 days ago at the time, but I had updated the v1 release not realizing there had been a v2 release with this improvement already done.

Thanks for getting back to me man!

qfox commented 7 years ago

Nice to hear that :-)

Thank you for contribution!