Area tracker is not updating its position and size

veger / TLBE

TLBE - Time Lapse Base Edition

MIT License

9 stars 6 forks source link

Area tracker is not updating its position and size #27

Closed prescientmoon closed 2 years ago

prescientmoon commented 2 years ago

As you can see, the size seems to be kinda broken...

prescientmoon commented 2 years ago

it keeps taking screenshots of this one area 00686016-bity

veger commented 2 years ago

I am using the area tracker myself and it works. (at least for me :wink: ) Are you sure it is the active tracker on a/the camera?

The camera uses trackers to define the position and zoom factor of the screenshots, so a tracker on itself is not doing much (the base tracker, for example, keeps track of new buildings).

prescientmoon commented 2 years ago

hmm, perhaps I am doing something wrong:

veger commented 2 years ago

It all looks good on a first glance.

Are other trackers working correctly? Or are they all failing to work?
Are the cameras globally paused? (see tool button in the toolbar or use CONTROL + SHIFT + P shortcut)

I'll take a look when I am back home (in the evening) to see if I can reproduce the issue

prescientmoon commented 2 years ago

Not all the cameras are globally paused

It seems like all trackers are failing to work 🤔

prescientmoon commented 2 years ago

In the meantime, is there any good way to "reset" the state of the mod? Deleting and reinstalling it from the mod menu doesn't seem to do the job

veger commented 2 years ago

I was able to reproduce that the 'Area Tracker is misbehaving just as you showed:

Center and Size are not getting updated when changing top/right and bottom/left coordinates
Camera only grabs the tracker position when a new one is added and the Area Tracker is added to it. (so it is also pretty much broken)

The other trackers do work for me though, when they are active (they have the play icon in front of them). Can you see any screenshots being taken in the script-output/tlbe folder?

veger commented 2 years ago

hm... weird now that I do a more thorough test it is working properly (again)

Edit: Oh... now I see your issue:

Your Right coordinate is left of your Left coordinate... This is not allowed (hence the red color). If you swap their values, the red color should disappear and the center/size of the tracker should be calculated properly.

(I guess I messed up as well when quickly testing before)

prescientmoon commented 2 years ago

Ohhhhh, I'm stupid :p

Imma try it tomorrow

veger commented 2 years ago

no problem! also took me a while to see the issue :smile:

prescientmoon commented 2 years ago

Yep, works as expected!