veger / TLBE

TLBE - Time Lapse Base Edition
MIT License
9 stars 6 forks source link

adds a box on the map matching the currently captured region #48

Closed drdozer closed 1 year ago

drdozer commented 1 year ago

As per the issue, this is a draft that adds a box on the map that indicates the currently captured snapshot region.

drdozer commented 1 year ago

Resolved by adding a Camera.destroy(camera) method and calling it from within the gui script when cameras are deleted.

drdozer commented 1 year ago
  • The code is written in camelCase. Can you please update the variables you introduce (using with snake_case) to adhere to this?

I think I've resolved this for all publicly visible and top-level variable. The exceptions are the function-private variables half_width and half_height within the refreshChartTags method, as I found the camel case version here to be unreadable.

drdozer commented 1 year ago
  • When a transition is finished its special tags are not removed (it just don't show because the white tags are on top)

I believe this is now resolved, by hooking into the two lifecycle points in followTrackerSmooth where transition data is initialized and deleted.

drdozer commented 1 year ago

I've tested with multiple cameras, and it appears to work correctly. Also works correctly for area trackers, so I think I hooked into the correct place in the lifecycle events.

veger commented 1 year ago

I just reformatted the code (to prevent nonsense changed in the future)

veger commented 1 year ago

All looks good in game, so I'll merge :+1: