Closed drdozer closed 1 year ago
- When a camera is deleted, the tags are not removed
Resolved by adding a Camera.destroy(camera)
method and calling it from within the gui script when cameras are deleted.
- The code is written in
camelCase
. Can you please update the variables you introduce (using withsnake_case
) to adhere to this?
I think I've resolved this for all publicly visible and top-level variable. The exceptions are the function-private variables half_width
and half_height
within the refreshChartTags
method, as I found the camel case version here to be unreadable.
- When a transition is finished its special tags are not removed (it just don't show because the white tags are on top)
I believe this is now resolved, by hooking into the two lifecycle points in followTrackerSmooth
where transition data is initialized and deleted.
I've tested with multiple cameras, and it appears to work correctly. Also works correctly for area trackers, so I think I hooked into the correct place in the lifecycle events.
I just reformatted the code (to prevent nonsense changed in the future)
All looks good in game, so I'll merge :+1:
As per the issue, this is a draft that adds a box on the map that indicates the currently captured snapshot region.