search

veggiemonk / awesome-docker

:whale: A curated list of Docker resources and projects
https://awesome-docker.netlify.app
Apache License 2.0
30.61k stars 3k forks source link

Remove pull request checks #908

Closed veggiemonk closed 4 years ago

veggiemonk commented 4 years ago

It becomes too cumbersome to keep up with GitHub rate limiting. Putting a token inside is just not an acceptable choice for an open source project. Github Actions default token are not able to query the GraphQL api.

I have no other choice.

From now on, the checking of those links will be "best effort".

Let me know what you think

mashb1t commented 4 years ago

Hey @veggiemonk,

I wouldn't remove the functionality altogether because one part is reaching rate limits but keep it for manual checks.

suggestion for our GitHub action:

This way we can at least keep some of the checking functionality on GitHub actions instead of throwing it out completely.

In addition to the GitHub action on PR we can create a separate script deriving from your pr_check_gql.js/pull_request.js (or just using it) for manually running checks for links once in a while or before merging a PR with a personal token.

What do you think?

veggiemonk commented 4 years ago

Good idea! Let's do that. 👍

agebhar1 commented 4 years ago

Sounds good to me too :+1: