veggiemonk / awesome-docker

:whale: A curated list of Docker resources and projects
https://awesome-docker.netlify.app
Apache License 2.0
30.61k stars 3k forks source link

Add Krane #924

Closed david-castaneda closed 3 years ago

david-castaneda commented 3 years ago

Quality Standards

Note that we can help you achieve those standards, just try your best and be brave. We'll guide you to the best of our abilities.

To be on the list, it would be nice if entries adhere to these quality standards:

To be on the list, the project must have:

If your PR is not merged, we will tell you why so that you may be able to improve it. But usually, we are pretty relaxed people, so just come and say hi, we'll figure something out together.

Rules for Pull Request

Please contribute links to packages/projects you have used or are familiar with. This will help ensure high-quality entries.

Your commit message will be a tweet so write a good commit message, keep that in mind :)

welcome[bot] commented 3 years ago

Thank you for contributing. Please check out our contributing guidelines and welcome!

mashb1t commented 3 years ago

@david-castaneda thank you for the contribution and for following the guidelines. As already mentioned by @dmitrytokarev the repository of Krane doesn't have a license (neither as separate file nor in the readme), so it would be great if you could either clarify this and/or add a license to it. You can select one e.g. here: https://choosealicense.com/

Nevertheless some tests do currently fail, so we have to fix them first before merging, which i could do tomorrow.

david-castaneda commented 3 years ago

@mash1t Added the license ✅

welcome[bot] commented 3 years ago

Congrats on merging your first pull request! Checkout the twitter account (https://twitter.com/awesome_docker) to see your PR :D