search

vegidio / flutter-appodeal

A Flutter plugin to display ads from Appodeal; it supports consent dialog to track users.
https://pub.dev/packages/appodeal_flutter
MIT License
31 stars 19 forks source link

Add some methods and fix crash at startup #10

Closed tommybuonomo closed 3 years ago

tommybuonomo commented 3 years ago

Add the 2 methods disableLocationPermissionCheck and disableWriteExternalStoragePermissionCheck (cf https://wiki.appodeal.com/en/android/2-7-4-android-sdk-integration-guide/configure-sdk)

Fix a crash at startup because of illegal argument on the error response of the plugin. If the user starts the app without connection (no WIFI, no 4G) the app was crashing because of that on the method fetchConsentInfo

vegidio commented 3 years ago

@tommybuonomo Thanks for the PR. I will review it over the weekend!

houdayec commented 3 years ago

@vegidio @tommybuonomo Since this is a very important fix (otherwise, package is not usable in production), could you try to finish this PR? Also, @vegidio , I don't see any updates since a month ago, did you drop the package? I know it requires time to maintain, I just want to know.

vegidio commented 3 years ago

@houdayec I will gladly merge the PR as soon as I hear something from @tommybuonomo with the comments that I put in his change.

As for the package itself, it indeed doesn't have any change for quite some time, but it's not abandoned yet. I just need to focus on my primary job right now so unfortunately I cannot dedicate my time to this or any other personal project that I have. I believe I will have time to work on this project again in the beginning of January.

Meanwhile any PRs are welcomed.

houdayec commented 3 years ago

@houdayec I will gladly merge the PR as soon as I hear something from @tommybuonomo with the comments that I put in his change.

As for the package itself, it indeed doesn't have any change for quite some time, but it's not abandoned yet. I just need to focus on my primary job right now so unfortunately I cannot dedicate my time to this or any other personal project that I have. I believe I will have time to work on this project again in the beginning of January.

Meanwhile any PRs are welcomed.

Thanks for your reply. You did a very great job so far! I am looking for such a package for months now, started to do my own on a side project but yours is definitely a lot more advanced. I am waiting for this PR to be merged (maybe I will take @tommybuonomo PR , make the changes and submit PR as he does not respond). I will also make some tests tomorrow to check if the package do not crash on iOS when phone is not connected to the Internet. I'm ready to help you as contributor on this one, keep going bud.

vegidio commented 3 years ago

@houdayec Thanks for helping with this! Looking forward for your changes 🙂

tommybuonomo commented 3 years ago

Hey guys, Sorry for the late, my primary job kept me busy during the last weeks. I'll do the changes today about the PR, and I'll check the behaviour on iOS :)

houdayec commented 3 years ago

Hey guys, Sorry for the late, my primary job kept me busy during the last weeks. I'll do the changes today about the PR, and I'll check the behaviour on iOS :)

Thanks for your reply. Let us know!

tommybuonomo commented 3 years ago

@vegidio @houdayec Changes done, let me know if it's ok for you ! I also added a new method on iOS to disable location tracking. Thanks

vegidio commented 3 years ago

@tommybuonomo Thanks for the changes! I will have a look either today or tomorrow and merge asap 🙂

vegidio commented 3 years ago

@tommybuonomo I just merged your PR. Thank you very much for the contribution. I will generate a new package and upload it to pub.dev later today 🏆

vegidio commented 3 years ago

@tommybuonomo @houdayec a new package was published on pub.dev. I bumped it to version 0.4.0 🚀

However, while I was trying to use the newest version of the package I got an error regarding Appodeal's TapJoy integration on iOS. This doesn't seem to be related to the changes that @tommybuonomo did and it's probably going to disappear when we bump the Appodeal plugin to the newest version.

There's already another PR #14 to upgrade Appodeal for the newest version so I will try to review it ASAP. So in case version 0.4.0 doesn't work yet for you on iOS due to this TapJoy integration, just wait a little more for this other PR 🙂