search

vehiclefits / vfmagento

A set of modules for adding vehicle specific features to your Magento shopping cart.
http://vehiclefits.com
Open Software License 3.0
22 stars 18 forks source link

include path needs to be after magentos #62

Open kylecannon opened 11 years ago

kylecannon commented 11 years ago

For performance reasons, we need to adjust from:


/var/www/www/lib/

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/..

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/joshribakoff/php-csv-utils/source

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/vehiclefits/vehicle-fits-core/library

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-timer

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-invoker

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-text-template

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-token-stream

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-file-iterator

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/phpunit-mock-objects

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-code-coverage

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/phpunit

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/symfony/yaml

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/phpunit-selenium

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/phpunit-story

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/dbunit

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/symfony/yaml

/var/www/www/app/code/local

/var/www/www/app/code/community

/var/www/www/app/code/core

/var/www/www/lib

to


/var/www/www/lib/

/var/www/www/app/code/local

/var/www/www/app/code/community

/var/www/www/app/code/core

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/..

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/joshribakoff/php-csv-utils/source

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/vehiclefits/vehicle-fits-core/library

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-timer

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-invoker

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-text-template

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-token-stream

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-file-iterator

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/phpunit-mock-objects

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/php-code-coverage

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/phpunit

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/symfony/yaml

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/phpunit-selenium

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/phpunit-story

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/phpunit/dbunit

/var/www/www/.modman/Vehicle-Fits-Magento/app/code/local/Elite/vendor/symfony/yaml
joshribakoff commented 11 years ago

I think composer is setting the include path. We' have to manipulate it after requireing composer, right? If so, I could suggest to explode() the include path into an array, then manipulate that array, then implode() it back to a string

kylecannon commented 11 years ago

Code should be in the bootstrap observer 

— Sent from Mailbox for iPhone

On Sat, Sep 28, 2013 at 11:36 AM, Josh Ribakoff notifications@github.com wrote:

I think composer is setting the include path. We' have to manipulate it after requireing composer, right? If so, I could suggest to explode() the include path into an array, then manipulate that array, then implode() it back to a string

Reply to this email directly or view it on GitHub: https://github.com/vehiclefits/vfmagento/issues/62#issuecomment-25305739

joshribakoff commented 11 years ago

Yeah but we don't really manipulate the include path there. Composer internally sets the include path. So we should modify it after composer sets it, right? Composer is the one that "chose" to put Magento last.

joshribakoff commented 11 years ago

And also what if other people are using other extensions that modify the include_path? We can't assume that the include path itself is an invariant.. maybe this should be a setting optomizeIncludePathForPerformance that defaults to false. Users can turn it on to get a small performance boost, and the documentation will explain the potential tradeoffs in doing so