search

veidenberg / wasabi

Wasabi is a web-based tool for evolutionary sequence analysis. Homepage: http://wasabiapp.org
GNU Affero General Public License v3.0
16 stars 7 forks source link

Load tree and msa files from 2 urls at the same time fails #4

Closed smoretti closed 6 years ago

smoretti commented 6 years ago

I try to load a tree and an msa file at the same time following http://wasabiapp.org/rest/ documentation but it fails.

It works perfectly with a single url=source but I cannot get two url sources loaded (tree and msa). I tried with %26 and & but for both the import panel opens itself and runs indefinitely.

veidenberg commented 6 years ago

Failure to import from multiple url sources is a known bug. Fix requires only minor code changes so look for a github push soon.

On 20 Nov 2017, at 14.16, smoretti notifications@github.com<mailto:notifications@github.com> wrote:

I try to load a tree and an msa file at the same time following http://wasabiapp.org/rest/ documentation but it fails.

It works perfectly with a single url=source but I cannot get two url sources loaded (tree and msa). I tried with %26 and & but for both the import panel opens itself and runs indefinitely.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/veidenberg/wasabi/issues/4, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABKM1ESoiEEN68zsnqAdxLrbkW3CfKn7ks5s4W2DgaJpZM4QkLGb.

smoretti commented 6 years ago

Great! Thanks

veidenberg commented 6 years ago

The latest commit should to fix it and import data from multiple url parameters (separated with '&'). If it doesn't work for you, add a comment with a pair of example URLs.

smoretti commented 6 years ago

It works for me with my toy example, url parameters separated with '&'.

I have just an empty error popup than opens itself when loading tree (Newick or NHX) and alignment (fasta) at the same time. See screenshot from 2017-11-27 13-15-58

Examples come from

Firefox 57.0 (64 bits), Ubuntu xenial

veidenberg commented 6 years ago

No error on wasabiapp.org when loading these files. Also, the tree view should not cut out the 'XPC' prefix from leaf names. Did you use the current version of the tree parser script (lib/jsphylosvg.rebuild.js)?

smoretti commented 6 years ago

I have the same error on my machine with Firefox and Chrome. My local git repo is up-to-date.

The XPC prefix did not appear because I did the screenshot with the NHX tree, and the S tag (species) is displayed instead of the leaf label.

veidenberg commented 6 years ago

Can't reproduce with my local repo. I added a commit to mute empty error dialogs (console trace instead). Import from multiple urls seems to work.