restore backup - delete backup and a few function / tweak

[Rarder44]

Hi, I added the ability to restore backups with a small menu. I added some code support functions and I slightly modified your Backup_savefile code to optimize the shift of the backups (since now they can also be deleted).

I indented everything correctly. I tried to change the rest of the code as little as possible, so I didn't put some strings in the lang file (and other improvements could be made)

The code can be compiled and is functional (from the first tests).

I honestly see that the base code is written a little bad ... I was thinking of modifying it a bit all to insert new features (file management etc. etc.), would you like to collaborate?

PS: I am Italian and yes, I used google translate to translate this text xD

[veikkos]

Hi!

Grazie for the effort!

However I intent to keep the kernel fairly close to the original and keep the patch compatibility with other kernels, so I prefer not to have indentation changes to existing code if possible. This way I can easily cherry-pick changes from other kernels if needed and others can pick changes from mine. Also if one day new official kernel version is released, it would be very difficult for me to apply it if all files have changed. Change of "+2,024 −32,029" lines is unfortunately not something I wish to integrate.

Also I believe that it's not very good idea to urge users to restore their backups directly on the console. That's because every game start creates a new backup and it's easy to lose track which backup is which and after few tries you might have lost the backup you needed. Therefore I think it's better that users take all the backup files to their computer to safety and attempt restore from there.

Mi dispiace I need to turn this change down, but feel free to release your own changes on top of mine if you wish. Please just clearly mark that it has your changes to avoid confusion.

If you want to discuss about having smaller subset of these changes or you have other ideas please consider opening an Issue for me and we can discuss.

PS. Google translate did a good job!

[Rarder44]

I answer you here (and not on the email).

I understand your perspective; unfortunately I had in mind, unlike you ( :P ) to modify a lot.

Since the last update of the official kernel dates back more than a year ago (and the code not correctly indented kills me a little inside), I immediately proceeded to indent the file.

My idea was to configure vscode to speed up the "debugging" process, clean and reorganize the code, implement simple and structured methods to implement new themes (a little on your idea) and languages, and possibly think about to mix C / C ++, or also considering a total migration to C ++. I also find that restoring backups directly from the gameboy is a very useful function (in the code I sent you, I had provided a menu that displayed the backup date and time to trace the most appropriate backup). Obviously these are drafts of ideas that need to be expanded.

so I think our two development ideas are totally divergent xD

If however you are interested in some aspect, or if in the future you see some modification that you are interested in implementing, I am always available! (of course, I will occasionally continue to take a look at your commits!)