search

vein-lang / vein

🔮⚡️Vein is an open source high-level strictly-typed programming language with a standalone OS, arm and quantum computing support.
https://vein-lang.org
MIT License
47 stars 6 forks source link

Application Binary Interface #227

Closed 0xF6 closed 3 months ago

0xF6 commented 3 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The Ishtar virtual machine has undergone significant updates, enhancing JIT compilation, garbage collection, and native library interactions. These changes introduce new functionalities like memory management improvements, detailed debugging features, and enhanced error handling. Test methods have been added, and project configurations adjusted to support experimental features, ensuring robustness and efficiency in runtime operations.

Changes

Files Affected Summary of Changes
Program.cs Significant modifications to TestJitFunctional, addition of TestJit2 method for native library interaction.
VirtualMachine.cs Initialization of VMConfig, addition of HasFaulted() method, and NativeStorage field.
FFI/ForeignFunctionInterface.cs Removed System.Runtime.InteropServices import statement.
__builtin/B_NAPI.cs Modified variable assignment to use current.vm.NativeStorage.
runtime/AppVault.cs Renamed WorkDirecotry to WorkDirectory, removed vein.fs import.
runtime/jit/ABI.cs Introduced ABI class for native library and symbol loading.
runtime/jit/AssemblerArgumentConverter.cs Added methods for generating assembler code and converting arguments.
runtime/jit/AssemblerFormatterOutputImpl.cs Introduced AssemblerFormatterOutputImpl class.
runtime/jit/IshtarJIT.cs Added JIT compilation functionality in the Ishtar virtual machine.
runtime/jit/NativeCallData.cs Introduced NativeCallData struct for native call information.
runtime/jit/NativeCallInfo.cs Added retIsPointer property to NativeCallInfo class.
runtime/jit/RegisterEx.cs, RegisterKind.cs Introduced utility classes for register management.
runtime/jit/TypeMarshalBox.cs Added TypeMarshalBox record for size and class information.
runtime/jit/x64_AssemblerStep.cs Introduced x64_AssemblerStep struct for assembler code generation.
runtime/vin/NativeStorage.cs Updated NativeStorage class with VirtualMachine parameter and instance members.
runtime/vin/loaders/NullLoader.cs Introduced NullLoader class implementing INativeLoader interface.

🐇✨ In the code's maze, through twists and turns, A rabbit hops, as the machine learns. With each leap and bound, New paths are found, In bytes and bits, the progress churns. 🌟🐾

Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 81eb42fcb0d89947dbb1919209da3a634a6bd20b and 52d3aec8fcfc669cfe364a4e458755ef4e9f9644.
Files selected for processing (1) * runtime/ishtar.vm/VirtualMachine.cs (4 hunks)
Files skipped from review as they are similar to previous changes (1) * runtime/ishtar.vm/VirtualMachine.cs
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
0xF6 commented 3 months ago

226