Closed 0xF6 closed 2 months ago
The changes primarily involve updating various method signatures and class structures to use pointers for CallFrame
and IshtarObject
parameters. This shift to pointer usage aims to enhance performance and memory management within the Ishtar VM. Additionally, some classes have been marked as unsafe
, and several methods have been refactored to handle exceptions and memory disposal more effectively.
File Path | Change Summary |
---|---|
runtime/ishtar.vm/DefaultWatchDog.cs |
Made DefaultWatchDog class unsafe, updated FastFail method to accept CallFrame* , adjusted ValidateLastError logic. |
runtime/ishtar.vm/FFI/ForeignFunctionInterface.cs |
Updated method signatures to use pointers for CallFrame and IshtarObject parameters. |
runtime/ishtar.vm/IAssemblyResolver.cs |
Changed sys_frame property type from CallFrame to CallFrame* . |
runtime/ishtar.vm/IWatchDog.cs |
Marked IWatchDog interface as unsafe , updated FastFail method to accept CallFrame* . |
runtime/ishtar.vm/NativeExports.cs |
Commented out logic in VM_EXECUTE_METHOD function. |
runtime/ishtar.vm/Program.cs |
Refactored CallFrame creation, updated exception handling, added frame->Dispose() . |
runtime/ishtar.vm/SmartPointer.cs |
Updated SmartPointer<T> struct to use pointers for CallFrame in constructor parameters. |
runtime/ishtar.vm/Trace.cs |
Changed IshtarTrace class to struct, removed constructor, made useConsole and useFile instance variables. |
runtime/ishtar.vm/VirtualMachine.cs |
Modified method declarations and logic within VirtualMachine class. |
runtime/ishtar.vm/__builtin/B_App.cs |
Updated method signatures to use pointers for CallFrame parameter. |
runtime/ishtar.vm/__builtin/B_Field.cs |
Updated method signatures to use pointers for CallFrame parameter. |
runtime/ishtar.vm/__builtin/B_File.cs |
Disabled original functionality in GetFileInfo function. |
runtime/ishtar.vm/__builtin/B_Function.cs |
Updated Call and Create functions to accept CallFrame* , commented out exception logic. |
runtime/ishtar.vm/__builtin/B_GC.cs |
Updated method signatures to use pointers for CallFrame parameter. |
runtime/ishtar.vm/__builtin/B_IEEEConsts.cs |
Updated getHalfNaN function to accept CallFrame* . |
runtime/ishtar.vm/__builtin/B_Out.cs |
Updated FPrintLn and FReadLine functions to accept CallFrame* . |
runtime/ishtar.vm/__builtin/B_String.cs |
Updated function signatures to accept CallFrame* . |
runtime/ishtar.vm/__builtin/B_Sys.cs |
Updated method signatures to use pointers for CallFrame parameter. |
runtime/ishtar.vm/__builtin/B_Type.cs |
Updated method signatures to use pointers for CallFrame parameter. |
runtime/ishtar.vm/__builtin/mappings/sys/Marshals.cs |
Updated GetFor method to accept CallFrame* , used pointer dereferencing for frame references. |
runtime/ishtar.vm/__builtin/mappings/sys/TransitAllocator.cs |
Changed RuntimeType method signature to accept CallFrame* . |
runtime/ishtar.vm/collections/NativeList.cs |
Added UnsafeVoid_Delegate<T> delegate to take a pointer to T where T is unmanaged. |
runtime/ishtar.vm/ishtar.vm.csproj |
Added project reference to ishtar.vm.libuv.csproj . |
runtime/ishtar.vm/runtime/IshtarArray.cs |
Changed parameter type from CallFrame to CallFrame* in indexer, Get , and Set methods. |
runtime/ishtar.vm/runtime/IshtarFrames.cs |
Changed IshtarFrames class to struct, updated constructor and method implementations. |
runtime/ishtar.vm/runtime/IshtarMarshal.cs |
Updated method signatures to include CallFrame* parameter. |
In the land of code so bright and clear,
Pointers dance, no need to fear.
Frames and objects now take flight,
Enhancing speed, a coder's delight.
With every change, we celebrate,
A rabbit's joy, we iterate.
๐โจ
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
Refactor
CallFrame
parameters across multiple files.IshtarTrace
from a class to a struct and removed its constructor.CallFrame
creation and exception handling inProgram.cs
.Chores
ishtar.vm.libuv.csproj
.These changes aim to enhance performance and memory management within the Ishtar VM.