search

vein-lang / vein

🔮⚡️Vein is an open source high-level strictly-typed programming language with a standalone OS, arm and quantum computing support.
https://vein-lang.org
MIT License
47 stars 6 forks source link

CallFrame now a struct #235

Closed 0xF6 closed 2 months ago

0xF6 commented 2 months ago

Summary by CodeRabbit

These changes aim to enhance performance and memory management within the Ishtar VM.

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes primarily involve updating various method signatures and class structures to use pointers for CallFrame and IshtarObject parameters. This shift to pointer usage aims to enhance performance and memory management within the Ishtar VM. Additionally, some classes have been marked as unsafe, and several methods have been refactored to handle exceptions and memory disposal more effectively.

Changes

File Path Change Summary
runtime/ishtar.vm/DefaultWatchDog.cs Made DefaultWatchDog class unsafe, updated FastFail method to accept CallFrame*, adjusted ValidateLastError logic.
runtime/ishtar.vm/FFI/ForeignFunctionInterface.cs Updated method signatures to use pointers for CallFrame and IshtarObject parameters.
runtime/ishtar.vm/IAssemblyResolver.cs Changed sys_frame property type from CallFrame to CallFrame*.
runtime/ishtar.vm/IWatchDog.cs Marked IWatchDog interface as unsafe, updated FastFail method to accept CallFrame*.
runtime/ishtar.vm/NativeExports.cs Commented out logic in VM_EXECUTE_METHOD function.
runtime/ishtar.vm/Program.cs Refactored CallFrame creation, updated exception handling, added frame->Dispose().
runtime/ishtar.vm/SmartPointer.cs Updated SmartPointer<T> struct to use pointers for CallFrame in constructor parameters.
runtime/ishtar.vm/Trace.cs Changed IshtarTrace class to struct, removed constructor, made useConsole and useFile instance variables.
runtime/ishtar.vm/VirtualMachine.cs Modified method declarations and logic within VirtualMachine class.
runtime/ishtar.vm/__builtin/B_App.cs Updated method signatures to use pointers for CallFrame parameter.
runtime/ishtar.vm/__builtin/B_Field.cs Updated method signatures to use pointers for CallFrame parameter.
runtime/ishtar.vm/__builtin/B_File.cs Disabled original functionality in GetFileInfo function.
runtime/ishtar.vm/__builtin/B_Function.cs Updated Call and Create functions to accept CallFrame*, commented out exception logic.
runtime/ishtar.vm/__builtin/B_GC.cs Updated method signatures to use pointers for CallFrame parameter.
runtime/ishtar.vm/__builtin/B_IEEEConsts.cs Updated getHalfNaN function to accept CallFrame*.
runtime/ishtar.vm/__builtin/B_Out.cs Updated FPrintLn and FReadLine functions to accept CallFrame*.
runtime/ishtar.vm/__builtin/B_String.cs Updated function signatures to accept CallFrame*.
runtime/ishtar.vm/__builtin/B_Sys.cs Updated method signatures to use pointers for CallFrame parameter.
runtime/ishtar.vm/__builtin/B_Type.cs Updated method signatures to use pointers for CallFrame parameter.
runtime/ishtar.vm/__builtin/mappings/sys/Marshals.cs Updated GetFor method to accept CallFrame*, used pointer dereferencing for frame references.
runtime/ishtar.vm/__builtin/mappings/sys/TransitAllocator.cs Changed RuntimeType method signature to accept CallFrame*.
runtime/ishtar.vm/collections/NativeList.cs Added UnsafeVoid_Delegate<T> delegate to take a pointer to T where T is unmanaged.
runtime/ishtar.vm/ishtar.vm.csproj Added project reference to ishtar.vm.libuv.csproj.
runtime/ishtar.vm/runtime/IshtarArray.cs Changed parameter type from CallFrame to CallFrame* in indexer, Get, and Set methods.
runtime/ishtar.vm/runtime/IshtarFrames.cs Changed IshtarFrames class to struct, updated constructor and method implementations.
runtime/ishtar.vm/runtime/IshtarMarshal.cs Updated method signatures to include CallFrame* parameter.

Poem

In the land of code so bright and clear,
Pointers dance, no need to fear.
Frames and objects now take flight,
Enhancing speed, a coder's delight.
With every change, we celebrate,
A rabbit's joy, we iterate.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.