search

vein-lang / vein

🔮⚡️Vein is an open source high-level strictly-typed programming language with a standalone OS, arm and quantum computing support.
https://vein-lang.org
MIT License
47 stars 6 forks source link

[methods aliases] Features for Function Type and load function as argument #250

Closed 0xF6 closed 1 month ago

0xF6 commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The updates span core compiler functionalities, including handling of generics, method compatibility checks, and opcode definitions. Key enhancements involve concatenating and regenerating aliases, defining delegate classes, improving type handling for method arguments, and introducing new opcodes (CALL_SP, LDFN). Additionally, version increments, reflection adjustments, and IL generation refinements contribute to a more robust and flexible compilation process.

Changes

File Path Change Summary
compiler/compilation/CompilationTask.cs Added steps to concatenate aliasesQueue items and regenerate aliases before proceeding with existing compilation logic
compiler/compilation/parts/args.cs Introduced conditional checks based on method.IsMethodType, modifying generics handling, constraints, and VeinArgumentRef generation
compiler/compilation/parts/classes.cs Added methods like DefineDelegateClass and adjusted LinkClasses and RegenerateAliases for alias handling
compiler/compilation/parts/methods.cs Used constants for constructor method names
lib/ast/syntax/VeinSyntax.cs Adjusted parsing of method bodies by introducing a Positioned() method call
metadata/db_opcodes.json Added new entries for "CALL_SP": 114 and "LDFN": 115
metadata/opcodes.def.cs Added new opcodes CALL_SP and LDFN to OpCodeValue enum
metadata/opcodes.list.def.cs Updated SetVersion value to 20, added new opcodes CALL_SP and LDFN
metadata/opcodes.yaml Added entries for CALL_SP and LDFN
metadata/version Incremented version number from 18 to 20
runtime/common/reflection/VeinClass.cs Introduced FindAnyMethods and extended compatibility checks. Removed outdated compatibility check methods
runtime/common/reflection/VeinMethod.cs Added method NotThis, HasCompatibility, and constants for method names. Updated method name checks to use constants
runtime/common/reflection/VeinTypeCode.cs Added TYPE_RAW case to type code mapping
runtime/ishtar.base/emit/ClassBuilder.cs Modified DefineMethod to change returnType parameter to VeinComplexType
runtime/ishtar.base/emit/ILGenerator.cs Introduced handling for new LDFN opcode
runtime/ishtar.base/emit/MethodBuilder.cs Updated returnType parameter type from VeinClass to VeinComplexType in constructor
runtime/ishtar.base/emit/VeinModuleBuilder.cs Added method DefineClass with parent class
runtime/ishtar.generator/GeneratorContext.cs Extensive changes for handling method creation, field resolution, and error handling
runtime/ishtar.generator/generators/access.cs Updated EmitAccess method to call GetTypeCode(ctx)
runtime/ishtar.generator/generators/call.cs Added IsCallingDelegate method
runtime/ishtar.generator/generators/emitters.cs Updated EmitCreateObject method to use constant for constructor method name
runtime/ishtar.generator/generators/operators.cs Added context handling for unary expressions
runtime/ishtar.generator/generators/types.cs Enhanced type code determination to handle different expressions

Poem

In code's vast realm, we weave anew,
With opcodes fresh and constructs, too.
Aliases linked and methods clear,
A rabbit's touch, no bugs to fear.
A poet's heart within our bytes,
We celebrate these new heights! 🎉

[!TIP]

Early access features - OpenAI `gpt-4o` model for reviews and chat. Note: - You can disable early access features from the CodeRabbit UI or by setting `early_access: false` in the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are always opted into early access features.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.