search

vein-lang / vein

🔮⚡️Vein is an open source high-level strictly-typed programming language with a standalone OS, arm and quantum computing support.
https://vein-lang.org
MIT License
47 stars 6 forks source link

Implementation of LDFN & CALL_SP, and some fixes delegate calling #251

Closed 0xF6 closed 1 month ago

0xF6 commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

Overall, the changes enhance method compatibility checks, introduce new enum values, improve code generation and runtime handling, and refine memory management. The updates focus on adding arguments, refining logic for argument handling, enhancing exception handling, and introducing new memory allocation methods.

Changes

File Change Summary
.../common/reflection/VeinClass.cs Modified CheckCompatibilityFunctionClass to pass an additional boolean argument to HasCompatibility
.../common/reflection/VeinMethod.cs Updated HasCompatibility to include a new ignoreThis parameter and adjusted compatibility logic accordingly
.../common/reflection/VeinTypeCode.cs Added a new enum value TYPE_NULL to VeinTypeCode
.../ishtar.generator/GeneratorContext.cs Adjusted method signatures and parameter handling in CreateFunctionMulticastGroup, including changes in code generation logic
.../ishtar.generator/generators/call.cs Modified EmitCall and IsCallingDelegate methods to include additional arguments and an instruction emission
.../ishtar.generator/generators/operators.cs Removed gen.Emit(OpCodes.LDNULL); and modified parameters in call to FindMethod
.../ishtar.vm/VirtualMachine.cs Added argument validation logic before method execution, replaced ForceFail, and introduced new opcodes and enhanced exception handling
.../ishtar.vm/runtime/IshtarMarshal.cs Updated UnBoxing to handle null input by returning a stackval with type = TYPE_NULL and added a default case throwing NotImplementedException
.../ishtar.vm/runtime/gc/IshtarGC.cs Added new methods AllocRawValue and FreeRawValue for memory allocation and deallocation
.../ishtar.vm/runtime/vm/CallFrame.cs Added a check in FillStackTrace method before assigning to frame->exception.stack_trace
.../ishtar.vm/stackval.cs Added new structures and methods for memory allocation including rawval_union, VeinRawCode, and rawval
.../ishtar.vm/vm.switch.cs Added a new boolean property DisableValidationInvocationArgs for validation control

Poem

In code realms where logic blooms,
We shaped new paths with digital plumes.
Methods check with finer grace,
Nulls are caught in memory's embrace.
Validation shines in fresh delight,
As bytes dance in the VM's light.
Here’s to progress, pure and bright! 🌟

[!TIP]

Early access features: enabled We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are always opted into early access features.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.