veiset / poe-vendor-string

Path of Exile Vendor Search tool
61 stars 17 forks source link

Suggest adding feature: regex for maps name #102

Closed md3848 closed 11 months ago

md3848 commented 11 months ago

Suggest adding feature: regex for maps name

veiset commented 11 months ago

Would you typically use this together with the map mods regex, or is the use case generic?

md3848 commented 11 months ago

First, I want to filter my favorite maps (regex-maps-name), so that I can easily select them and transfer them to Folder/stab-tab craft. Then after crafting the maps, I use regex-mods and recraft maps with bad mods.

Your site is good for people who only have 1 favorite map and only spam one map, but for people like me, having this feature on your site (which I requested) is useful.

On your site, I prefer to have this feature in a separate tab; Because the [Map modifiers] tab It's busy right now! image

vinhvizg1040 commented 11 months ago

I tried doing it, and it worked on my forked. Take it and try it for yourself. my forked: https://github.com/vinhvizg1040/poe-vendor-string

image

veiset commented 11 months ago

Really really awesome stuff!! 😁 If you want you can make a PR and I'll fix up the merge conflicits from some other stuff I am currently working on.

veiset commented 11 months ago

You can check out the profile stuff in this PR:

https://github.com/veiset/poe-vendor-string/pull/105

veiset commented 11 months ago

Thanks. This is now live on poe.re! Let me know if you find any issues with the regex generated.