veiset / poe-vendor-string

Path of Exile Vendor Search tool
61 stars 17 forks source link

"ike" for increased Critical Strike Chance also marks reduced extra crit #18

Closed verysecrethero closed 2 years ago

verysecrethero commented 2 years ago

hello, use "mult" instead of "ike" for increased Critical Strike Chance since "ike" also marks reduced Extra Damage from Critical Strikes

veiset commented 2 years ago

It uses ike (with the space), not ike, so ike should not match reduced Extra Damage from Critical Strikes.

Do you have an example of a map that falsly matches a query? I will look in to it and fix it if there is an issue. Could you please copy the text of the map (hoved it and click ctr+c) and the exact search query you used?

verysecrethero commented 2 years ago

hello ok good suggestion to show a map, ok here we go, i will add a couple of examples, if i use "ike " this matches:

Item Class: Maps Rarity: Rare Vortex Panorama Beach Map

Map Tier: 16 Item Quantity: +63% (augmented) Item Rarity: +29% (augmented) Monster Pack Size: +19% (augmented) Quality: +14% (augmented)

Item Level: 84

Monsters Poison on Hit Monsters take 37% reduced Extra Damage from Critical Strikes Monsters gain 41% of Maximum Life as Extra Maximum Energy Shield Buffs on Players expire 70% faster

Travel to this Map by using it in a personal Map Device. Maps can only be used once.

if i use "ike " !mult i get several matches in my maprolls box: Item Class: Maps Rarity: Rare Ancestral Refuge Shore Map

Map Tier: 16 Item Quantity: +78% (augmented) Item Rarity: +46% (augmented) Monster Pack Size: +30% (augmented)

Item Level: 85

Area is inhabited by Undead Players are Cursed with Temporal Chains Monsters deal 92% extra Physical Damage as Lightning Monsters take 38% reduced Extra Damage from Critical Strikes Monsters cannot be Taunted Monsters' Action Speed cannot be modified to below base value Players cannot Regenerate Life, Mana or Energy Shield

Travel to this Map by using it in a personal Map Device. Maps can only be used once.

Item Class: Maps Rarity: Rare Stained Roost Wasteland Map

Map Tier: 16 Item Quantity: +49% (augmented) Item Rarity: +29% (augmented) Monster Pack Size: +19% (augmented)

Item Level: 85

Players are Cursed with Elemental Weakness Monsters reflect 18% of Elemental Damage Monsters take 38% reduced Extra Damage from Critical Strikes Unique Bosses are Possessed

Travel to this Map by using it in a personal Map Device. Maps can only be used once.

Item Class: Maps Rarity: Rare Dream Panorama Shore Map

Map Tier: 16 Item Quantity: +49% (augmented) Item Rarity: +29% (augmented) Monster Pack Size: +19% (augmented)

Item Level: 85

Area is inhabited by Humanoids Monsters have 70% chance to Avoid Elemental Ailments Cannot Leech from Monsters Monsters take 37% reduced Extra Damage from Critical Strikes

Travel to this Map by using it in a personal Map Device. Maps can only be used once.

let me know if u need more examples or can explain the issue :) thanks

veiset commented 2 years ago

Thanks! I will look in to this later today!

verysecrethero commented 2 years ago

ok i had a hunch and i checked it, it only happens if you have "ike " in the end of the regex or just "ike " if you try "ike |ail" then it will not mark the reduced crit ones so what happens is probably that poe trims the end of the regex and gets rid of the extra space if you have "ike " in the end

veiset commented 2 years ago

Oh! Thanks for finding the issue. I'll update the generator this evening and update the page. I'll let you know when it's live. This will probably fix similar issues in a few other cases as well.

veiset commented 2 years ago

I had some time during lunch. It should be resolved now 😁 Can you verify it solves the problem? poe.re is updated with the new regex

verysecrethero commented 2 years ago

hello, nice! good idea to make it "ke c" instead and i see you changed 2 other things as well ive tested it and the new regex seems to work fine now good job, thanks for the update and the tool is very nice and useful

veiset commented 2 years ago

Great! Thanks for taking the time to do some digging.

I got a tool that automatically generates the regexes, which also does a lot of checks to hopefully ensure the results are correct, but in this case the regex in game was acting weirdly with the trim logic.

Just as a bonus fun fact: mult would have matched magic maps with the modifier Area has increased monster variety, since the modifier is named Multifarious 😅