search

veista / smartthings

A fork of the Home Assistant SmartThings Integration. This adds better support for Samsung OCF Devices.
170 stars 40 forks source link

OCF Refrigerator Not Showing Child Devices #22

Open markdepalma opened 2 years ago

markdepalma commented 2 years ago

I have a Samsung refrigerator, but am only getting data from the parent device. The child devices (Cooler/Freezer/Ice Maker) are not picked up. Mostly just interested in the freezer. All data shows up properly in the IDE. Happy to provide any additional information/data on this.

Model: RF22A4221SR Configured Type in IDE: Samsung OCF Refrigerator

chrisvball commented 2 years ago

same here... actually same issue with the official HA integration. child devices...

chrisvball commented 2 years ago

I take it back.. its working perfectly now. couple of restarts and good to go! Only thing that is missing is the power portion. At this point I have to assume its me!

dukyyuen commented 2 years ago

I had the same problem where the child devices weren't displaying. In particular, I was looking for the IceMaker. Even using the 1.1.13 version didn't do the trick for me. Seeing other posts where veista added the model 'ARTIK051_REF_17K', I looked that up in the code and found where that the model was being mentioned in 5 scripts (binary_sensor.py, number.py, select.py, sensor.py and switch.py). I added my model '20K_REF_LCD_FHUB5.0' next to '21K_REF_LCD_FHUB6.0' and now it works like a charm.

markdepalma commented 2 years ago

I had the same problem where the child devices weren't displaying. In particular, I was looking for the IceMaker. Even using the 1.1.13 version didn't do the trick for me. Seeing other posts where veista added the model 'ARTIK051_REF_17K', I looked that up in the code and found where that the model was being mentioned in 5 scripts (binary_sensor.py, number.py, select.py, sensor.py and switch.py). I added my model '20K_REF_LCD_FHUB5.0' next to '21K_REF_LCD_FHUB6.0' and now it works like a charm.

I did something similar, but I am having an issue the cooler/freezer doors updating from Closed -> Open, but not Open -> Closed. Also having issues with the ice maker status updating at startup.

jhhoffma3 commented 1 year ago

I had the same problem where the child devices weren't displaying. In particular, I was looking for the IceMaker. Even using the 1.1.13 version didn't do the trick for me. Seeing other posts where veista added the model 'ARTIK051_REF_17K', I looked that up in the code and found where that the model was being mentioned in 5 scripts (binary_sensor.py, number.py, select.py, sensor.py and switch.py). I added my model '20K_REF_LCD_FHUB5.0' next to '21K_REF_LCD_FHUB6.0' and now it works like a charm.

I'm hoping this leads to success to me, but how do I determine the model number in the format you list? My model is RS22T5201SR, but I don't see a reference to that anywhere, nor do I see any reference to the model you listed anywhere else. Is it somewhere else in the code once added to smartthings or HA? Is it the "mnmo" field in SmartThings (graph api)?

UPDATE: Figured it out. Used first part of "mnmo" value (everything before the pipe) listed in old "api.smartthings.com" site. Picture noted below image

jwelvaert commented 1 year ago

jhhoffma3

How did you view the mnmo? api.smartthings.com brings up 404. Is there another site or way to view it?

dukyyuen commented 1 year ago

@jwelvaert have you already installed the custom integration? If so, under HA, you should see the the model name, only without any childs:

image

jwelvaert commented 1 year ago

Thank you.

Swallowtail23 commented 1 year ago

Can confirm, I corrected child devices in the API, added "22K_REF_LCD_FHUB7.0" to the five files and additional devices as setup at the API now are loaded into the integration. At this stage I have two issues:

  1. Cooler temp is 3C according to the API page, but is pulled into HA as 20C
  2. Contact (any door) works correctly, but all other door sensors, while showing, always stay "Closed" in HA, don't go to Open or Closed on change
jhhoffma3 commented 1 year ago

For the 2nd part, I think those sensors only show open when the "Door Open Alarm" is triggered from the door being open too long. At least, that's how it worked on mine. The contact sensor is the instantaneous open/close alert for either door.

On Mon, Jan 16, 2023, 9:57 PM Swallowtail23 @.***> wrote:

Can confirm, I corrected child devices in the API, added "22K_REF_LCD_FHUB7.0" to the five files and additional devices as setup at the API now are loaded into the integration. At this stage I have two issues:

  1. Cooler temp is 3C according to the API page, but is pulled into HA as 20C
  2. Contact (any door) works correctly, but all other door sensors, while showing, always stay "Closed" in HA, don't go to Open or Closed on change

— Reply to this email directly, view it on GitHub https://github.com/veista/smartthings/issues/22#issuecomment-1384772595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO7QHSIRY76QOQ26W5SUSS3WSYDCJANCNFSM5W2MPBCA . You are receiving this because you commented.Message ID: @.***>

Swallowtail23 commented 1 year ago

For the 2nd part, I think those sensors only show open when the "Door Open Alarm" is triggered from the door being open too long. At least, that's how it worked on mine. The contact sensor is the instantaneous open/close alert for either door.

Gotcha. That makes sense, I'll test for that. Just the odd temp reading then to work out.

Swallowtail23 commented 1 year ago

OK I tested the Open/Closed for doors on my fridge (22K_REF_LCD_FHUB7):

I've updated API to show OCF child devices, and required child entities are visible in HA.

Change to "Contact" is pushed immediately; Open or Closed updates immediately upon any door opening or closing. The Child device Doors (e.g. Cooler Door) only update for me upon an integration reload. I see them reflect accurate status in the API, but this is not flowed into the integration immediately like the "Contact" sensor is. Reload the integration, it interrogates the API and the status is shown correctly. They also did not update when the fridge played its "door open too long" sound. After reloading the integration so "Cooler Door" reflected open, I closed the door, Contact immediately updated to Closed. 15 mins later, Cooler Door was still showing Open. An integration reload resolved it to Closed.

kernelpanic85 commented 1 year ago

I'm still not having any luck with my TP6X_REF_16K after adding it to the files. For those that got it working on their models, could you screenshot what your fridge looks like in the Smartthings IDE? What parent and child devices show up and what do you have their type set to?

DeathofaStar commented 1 year ago

Experiencing the same issue as kernelpanic85 on my TP2X_REF_20K. More details in issue below

https://github.com/veista/smartthings/issues/51#issuecomment-1629348221