veka0 / Deferred-Lighting-Shader

Colored lighting shader/add-on for Minecraft: Bedrock Edition 1.18.12 (mobile version) utilizing custom deferred rendering pipeline.
MIT License
21 stars 2 forks source link

Add to more cube types that can cast shadows #4

Open player868 opened 1 year ago

player868 commented 1 year ago

Would it be possible to add projection to more new cubes or more types of cubes? Currently there are too few types of shadow castable cubes, adding more types of cubes that can cast shadows would greatly increase the spectacle for large maps, and would be extremely important for building type cube projections. For example, large building/city maps and ornamental maps.

veka0 commented 1 year ago

Unfortunately it's not possible, not with the current method of detecting blocks at least, since it relies on block tags and not every block has a tag (see https://wiki.bedrock.dev/blocks/block-tags.html). If Mojang added an air tag, then it would be possible to add shadows to every single non-air block in the game. But unfortunately that's not the case. Rewriting block detection to use a different method would be a lot of work and likely have a very big hit on performance.

player868 commented 1 year ago

不幸的是,这是不可能的,至少不是用当前的检测块的方法,因为它依赖于块标签,而不是每个块都有一个标签(见 https://wiki.bedrock.dev/blocks/block-tags.html)。如果Mojang添加了空中标签,那么就可以为游戏中的每个非空中方块添加阴影。但不幸的是,事实并非如此。重写块检测以使用不同的方法将是一项繁重的工作,并且可能会对性能产生非常大的影响

If you can improve the optimization work, then it is worthwhile to handle a greater quantity. It would be a great pity if the production of cube types that support light source shadow projection were stopped solely for this reason. After opening the light source shadow projection project and entering the new update of version 1.18, we can see that the shadow projection effects in lush plant caves and deep rock caves seem to have remained unchanged. I believe that the light source shadow projection option should have a better effect on architectural or decorative maps, as these maps showcase the best decorative effects. However, I have found that only certain block types, such as stone, cobblestone, minerals, wooden slabs, wooden blocks, and iron blocks, support light source shadow projection. Other blocks do not support it (I have yet to discover other supported block types). The functionality of light source shadow projection should not be limited to merely appreciating mine shafts, ordinary wooden houses, or natural terrain; it should have a greater impact.