search

veken0m / bitcoinium

Bitcoinium is an Android application used to monitor Bitcoin price on various exchanges.
Other
47 stars 32 forks source link

Maven support #8

Closed dalb8 closed 7 years ago

dalb8 commented 11 years ago

We at F-Droid project would like to distribute the app. Since there are many jars and the pom.xml is more or less written in the readme and pom.xml of the xchange repo it would be good to have a pom.xml here. If the jars in this repo were to change often it would be tedious for us to verify them (in the case that they are sourced from upstream) or to manually build them one by one from source.

veken0m commented 11 years ago

@timmolter, lead developer of XChange, and I have tried to "mavenize" the project without any luck. If I remember correctly we were having issues with the Sherlock ActionBar library. Our attempt can be found in the "maven" branch, although it is very outdated. If someone would like to help me, I would be glad to add maven support.

dalb8 commented 11 years ago

Actually it turned out to be easy. The xchange jars can all be built from the pom.xml of the upstream repo and all the other jars are on mvnrepository and the versions are easily visible. So, this will probably be available via f-droid.org within the next few days. Sorry I'm not that knowledgable with maven to offer advice.

veken0m commented 11 years ago

That's great! Glad you got it working.

I noticed you are using the master branch, it is slightly out of date (1.4.0) . I had to rush out a couple of fixes when MtGox changed their API and haven't gotten around to updating the master. The develop branch is currently the most up to date at version 1.4.2 and contains MtGox API fix (as well as a couple of other nice tweaks).

Also if you could add my email: veken0m.apps@gmail.com and my bitcoin address: 1yjDmiukhB2i1XyVw5t7hpAK4WXo32d54 to the app description on F-Droid that would be great. Thanks!

dalb8 commented 11 years ago

It was great to have your widget over the last few days, but it was a bit crashy alright! I wouldn't usually look in develop branches but I should have really, having noticed the discrepancy with the Market and I should have also mentioned whick version we published. You could always tag releases: that is very convenient for us and it is branch independent. I did collect your Bitcoin address but we don't expose them in the F-Droid client yet. I will try using a non-http bitcoin uri because the client doesn't support copy/paste and if that doesn't work at least website users will be able to copy/paste. Not sure email will work for the same reason, but I'll try it.

dalb8 commented 11 years ago

We are holding back on building the latest version from the develop branch as we prefer to build the jars from source and well, it looks like too much work to build from all the different versions. 1.5.1 had bugs so I didn't build jars from source for 1.5.2

veken0m commented 11 years ago

The project is getting very convoluted, I apologize for that. I will attempt to clean things up this weekend as well as create a proper "master" branch to keep track of releases. It also seems that ActionBarSherlock fixed their issues with maven (https://github.com/JakeWharton/ActionBarSherlock/blob/master/CHANGELOG.md) so I might give mavenizing the project another try.

Also note that since 1.5.3 you will also need the colorPickerPreference library (https://github.com/attenzione/android-ColorPickerPreference). Perhaps I should include it in the project like I did with the graphing library to make things easier?

dalb8 commented 11 years ago

It's OK, we can source the library from elsewhere , although it would be good to document somewhere (readme, separate commit) which commit is used.

If the xchart jars can all be built with one command then that would suit us even better than maven, although if you need different versions maven is better, as long as the apk artifacts come from maven central.

veken0m commented 11 years ago

As you probably have noticed MtGox likes to change their API often. This forces me to release "rushed" updates using XChange develop branch snapshots which are not yet available on maven central. Hopefully this won't be the case for future updates and I will be able to rely on non-snapshot releases. If that remains the case you can easily fetch the latest builds here: https://oss.sonatype.org/content/groups/public/com/xeiam/xchange/ or compile them yourself using the XChange "develop" branch

dalb8 commented 11 years ago

Oh right, I did notice Mt Gox was broke again since last week . In that case I can put out a new build from develop branch

veken0m commented 11 years ago

Old master branch was a mess so I scraped it and made a new one from the develop branch. I also created a tag for v1.5.5 and will do so for subsequent releases. Tim will probably release XChange 1.7.0 containing the MtGox fix soon if you rather pull the jars from maven central.

veken0m commented 7 years ago

Closing this issue since Bitcoinium now uses Gradle for dependency management.