vekexasia
commented
7 months ago Can you please submit a pullreq?
On Tue, Dec 5, 2023, 10:43 pyzimmer @.***> wrote:
Hello, Thanks a lot for your job ! I use it for 2 years ! There are wrong units since your MQTT version : avoid heatind and cooling should be in Kwh, not Wh :
"avoided_heating_actual": {"unit": "W", "PDO": 213, "CONV": ComfoNumConvs.UINT16, "div": 100}, "avoided_heating_ytd": {"unit": "kWh", "PDO": 214, "CONV": ComfoNumConvs.UINT16}, "avoided_heating_total": {"unit": "kWh", "PDO": 215, "CONV": ComfoNumConvs.UINT16},
"avoided_cooling_actual": {"unit": "W", "PDO": 216, "CONV": ComfoNumConvs.UINT16, "div": 100}, "avoided_cooling_ytd": {"unit": "kWh", "PDO": 217, "CONV": ComfoNumConvs.UINT16}, "avoided_cooling_total": {"unit": "kWh", "PDO": 218, "CONV": ComfoNumConvs.UINT16},
— Reply to this email directly, view it on GitHub https://github.com/vekexasia/comfoair-esp32/issues/62, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQ6SYHSS7HZ7OE6A4256TYH3UE5AVCNFSM6AAAAABAHL4VYOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDKNZXGQ2DKMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Hello, Thanks a lot for your job ! I use it for 2 years ! There are wrong units since your MQTT version : avoid heatind and cooling should be in Kwh, not Wh :
https://github.com/vekexasia/comfoair-esp32/blame/c0a6ce86d21b86724e2f58828678d477c8b6f70f/components/comfoair/__init__.py#L46