vektah / gqlparser

A port of the parser from graphql-js into golang
MIT License
498 stars 123 forks source link

Github Actions for code linting / testing of PRs? #240

Closed philipaconrad closed 2 years ago

philipaconrad commented 2 years ago

Background

Github provides a CI/CD pipeline toolkit for free to open source projects, called Github Actions. On many larger open source projects, it's used to automate running test suites and linters against incoming PRs, easing the burden on maintainers, and improving the quality of submitted PRs.

Feature Request

Is there any interest in setting up automation like this in the future for this project?

StevenACoffman commented 2 years ago

Hi! The Circle CI setup currently runs test suites against incoming PRs, but adding linting is a good idea. I will add this as a GitHub Action, but I have not yet curated a good golangci-lint config for this repository. See #241 for an initial one.

philipaconrad commented 2 years ago

I've just gotten a working set of GH Actions workflows up on my fork. I'll send over a PR shortly. :+1: