Open vito opened 1 year ago
Hiya - we use errors.As here and noticed after bumping to v2.5.9 the error value is just a typed nil.
errors.As
It looks like this broke with this change because now it's only updating the local var within the As implementation.
As
The provided argument is already a pointer (and has to be otherwise you get linting errors), so it should just update it in-place.
go list -m github.com/vektah/gqlparser/v2
github.com/vektah/gqlparser/v2 v2.5.9
go version
What happened?
Hiya - we use
errors.Ashere and noticed after bumping to v2.5.9 the error value is just a typed nil.It looks like this broke with this change because now it's only updating the local var within the
Asimplementation.What did you expect?
The provided argument is already a pointer (and has to be otherwise you get linting errors), so it should just update it in-place.
Minimal graphql.schema and models to reproduce
versions
go list -m github.com/vektah/gqlparser/v2?github.com/vektah/gqlparser/v2 v2.5.9go version?