[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
Version of Golang used when building/testing:
[ ] 1.11
[ ] 1.12
[ ] 1.13
[ ] 1.14
[ ] 1.15
[ ] 1.16
[ ] 1.17
[ ] 1.18
[ ] 1.19
[ ] 1.20
[x] 1.21
[x] 1.22
How Has This Been Tested?
Unit tests on master fail on Go 1.22, but work on 1.21.
After the fix, both compilers are happy.
Narrowed it down to an internal panic in golang.org/x/tools, after upgrading to latest version of the lib and doing a go mod tidy, the crash went away. The lowest x/tools version that works is 1.13.
Checklist
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
Version of Golang used when building/testing:
How Has This Been Tested?
Unit tests on master fail on Go 1.22, but work on 1.21. After the fix, both compilers are happy.
Narrowed it down to an internal panic in golang.org/x/tools, after upgrading to latest version of the lib and doing a
go mod tidy
, the crash went away. The lowest x/tools version that works is 1.13.Checklist