add option package suffix and unit tests - Githubissues

vektra / mockery

A mock code autogenerator for Go

https://vektra.github.io/mockery/

BSD 3-Clause "New" or "Revised" License

5.8k stars 395 forks source link

add option package suffix and unit tests #762

Closed peczenyj closed 4 months ago

peczenyj commented 4 months ago

Description

Add option packagesuffix as an alternative to packageprefix (can be used together)

Why? I used to create packages like foo and foomock (instead mockfoo or mock_foo) and this option will be helpful.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Version of Golang used when building/testing:

[ ] 1.11
[ ] 1.12
[ ] 1.13
[ ] 1.14
[ ] 1.15
[ ] 1.16
[ ] 1.17
[ ] 1.18
[ ] 1.19
[ ] 1.20
[ ] 1.21
[X] 1.22

How Has This Been Tested?

I add unit tests

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

LandonTClipp commented 4 months ago

Hi, thanks for the PR and the interest in the project. According to our contributing guidelines, I would have preferred to discuss this as an issue beforehand. I am not looking to add any new features to the old (and deprecated) configuration style. You can get this feature for free if you use the packages config, specifically the outpkg parameter. For that reasoning I probably won't merge this.