vektra / mockery

A mock code autogenerator for Go
https://vektra.github.io/mockery/
BSD 3-Clause "New" or "Revised" License
5.8k stars 395 forks source link

fix: recursive config failure on windows #767

Closed stevenh closed 3 months ago

stevenh commented 3 months ago

Description

Fix failure with "package not found in config" on Windows due to use of backslash in package name instead of forward slash, resulting in the configuration for the sub package not being found.

Fixes: #727

Type of change

Version of Golang used when building/testing:

How Has This Been Tested?

Tested on Windows machine to be able to successfully run mockery when given a recursive configuration, confirming we now don't get a failure.

Checklist

A unit test for this is not possible as it depends on the OS specific slash separator in used in library functions.

LandonTClipp commented 3 months ago

Great! I have not added windows to our testing matrix yet because of a lot of other issues I don't recall at the moment. That would be a good project for someone to tackle eventually.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.61079%. Comparing base (8b86cf2) to head (426dc32).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #767 +/- ## =================================================== - Coverage 42.71105% 42.61079% -0.10026% =================================================== Files 63 63 Lines 4987 4987 =================================================== - Hits 2130 2125 -5 - Misses 2657 2662 +5 Partials 200 200 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.