fix(generator): support nil returns when using interface typed params - Githubissues

vektra / mockery

A mock code autogenerator for Go

https://vektra.github.io/mockery/

BSD 3-Clause "New" or "Revised" License

6.15k stars 412 forks source link

fix(generator): support nil returns when using interface typed params #835

Closed jfragosoperez closed 2 days ago

jfragosoperez commented 2 weeks ago

Description

Types using generic typed interface params, should allow nil values on return.
Some test/example mocks haven't been regenerated recently, so 'task mock' removed and recreated mocks taking into account the yaml config and package movements, etc.
Fixes #513

Type of change

[X] Bug fix (non-breaking change which fixes an issue)

Version of Go used when building/testing:

[ ] 1.22
[X] 1.23

How Has This Been Tested?

Added test coverage
Regenerate test mocks to reflect the changes (NOTE: interface{} renamed to any by default for new golang versions)
```
task mocks
task test
```

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

LandonTClipp commented 1 week ago

Thank you for the PR, this is on my radar so I will give it a review once I find some spare time... hopefully very soon 👍🏻

jfragosoperez commented 1 week ago

@LandonTClipp cool, I'll wait for your news, in case any changes were required, I'll apply them ASAP. Thanks

jfragosoperez commented 3 days ago

@LandonTClipp I rebased and squashed into a single commit, so you're able to merge (the workflow will need to run first though)