search

velaluqa / puppet-etherpad

UNMAINTAINED - Install and configure etherpad-lite via puppet for Debian
GNU General Public License v3.0
1 stars 4 forks source link

Use vcsrepo instead of exec #2

Open cjeanneret opened 10 years ago

cjeanneret commented 10 years ago

Hello,

would be great if this module could use puppet-vcsrepo instead of exec for the git clone/update…

Cheers,

C.

leoc commented 10 years ago

Hi,

I'd gladly do that. Do you know whether vcsrepo still notifies subscribed resources when checking for updates? I tried vcsrepo once (little time ago) and it notified all subscribed resources although there were no new commits for the tracked branch, leading to a restart of the subscribed services each time puppet agent did its service.

Cheers!

cjeanneret commented 10 years ago

Hello,

Hmm well, in fact I'm not that sure puppet should upgrade the etherpad… Especially since it's a git repository.

For example, what will happen if, for some reason, etherpad changes its configuration file format?

In a productive environment (like the one we'd like to create), we cannot cross our fingers :/.

For the answer itself: I don't know, as, here, we don't do git repository updates through puppet. Maybe it's corrected, maybe not, would be interesting asking puppetlabs (or Bruce) directly ;).

Cheers,

C.

Cédric Jeanneret Senior System Administrator Infrastructure Solutions

leoc commented 10 years ago

Puppet should not update etherpad automatically. The repository url, branch/commit should be set by the puppet modules version to ensure the correct configuration. I thought about updating when the puppet-module knows how to configure an update correctly. Then everything should update automatically.

Still in my setting puppet agent does run via a cron job. Every run (when vcsrepo checks for [non-existent] new commits) the service was restarted.

I created an issue in the puppetlabs tracker. Haven't heard anything yet though. I will have a try when I find some time in the next days. Maybe it was fixed in version > 1.0. :-)

Still, I am not sure about the best practices of software updates with puppet yet. I'd appreciate any hints on good readings. :+1:

igalic commented 9 years ago

to answer the main question above: puppetlabs-vcsrepo does, indeed, notify when something changes.

also, i agree with everyone here, that this module should only autoupdate when someone feels risky! ensure => 'latest', and all…