velbus / velbus-tcp-snap

Snap package for python-velbustcp
5 stars 1 forks source link

{Fault Tollerance} Restart on failure - USB removed #9

Open MDAR opened 3 years ago

MDAR commented 3 years ago

Hi

A silly thing, but there is no accounting for what happens in the field.

Can you add an automatic restart for when a user "accidentally" unplugs the USB connection.

It would seem that velbus-tcp doesn't close or show any sign of failure, other than the complete lack of traffic after unplugging and replugging the USB,.

"But nobody would do that in the real world"

Are the words I uttered 10 years ago in a meeting, but it would appear that I was wrong.

We added a restart-on-Failure=10 sec line to the service file of Velserv, because the whole app would exit when the USB was unplugged, so it was easy to try a restart every 10 seconds until the app stopped closing.

(This has done the trick and I stop getting silly phone calls now)

MDAR commented 2 years ago

@pvanloo

Have you got a change log I can read on this latest release?

We need to have a chat about a few things, no doubt Pieter will feedback after our chat next Monday

dukeofphilberg commented 2 years ago

Hi @MDAR the "changelog" can be found at https://github.com/velbus/python-velbustcp/releases/tag/1.6.0

There aren't many functional differences besides not containing the NTP module any more, the USB however should be more resilient.

dukeofphilberg commented 2 years ago

Please note that version 1.6.0 of the snap is still being rolled out on the edge channel and you will need to change the channel to get the latest version.

MDAR commented 12 months ago

Please note that version 1.6.0 of the snap is still being rolled out on the edge channel and you will need to change the channel to get the latest version.

Hey Philip

I'm curious

How does one "change channel" to get version 1.6 0?

Does this address the USB removal / restore issue?