search

velesin / jasmine-jquery

jQuery matchers and fixture loader for Jasmine framework
MIT License
1.89k stars 346 forks source link

Documentation about jQuery 3 #288

Closed miniplus closed 5 years ago

miniplus commented 8 years ago

I'm not able to find anything on jQuery 3 compatibility so I'm wondering whether or not this should be working as is right now?

If there is indeed nothing documented yet, I'd be best to add something about jQuery 3 for clarity. The only thing I managed to find was

jasmine-jquery is tested with jQuery 2.0 ..

miniplus commented 8 years ago

By using jQuery 3.1.0 and jQuery Migrate 3.0.0, I got some logs about removed or deprecated functionality. I quickly had a look at the source code and noticed 1 place where the deprecated jQuery method .size() was being used instead of the now common .length.

As .size() is removed in jQuery 3, this means this library is currently not compatible with jQuery 3. I didn't look into it any further as this answered my question, but I'm guessing there will be more breaking functionality.

cmrd-senya commented 7 years ago

Here is the log of the test suite invocation with jQuery 3.

There are 19 failures currently. So that requires some job to implement jQuery 3 support for this library.

cmrd-senya commented 7 years ago

I've opened a pull request #292 which fixes a major issue with jQuery 3 support. It isn't the only one, but looks like it is the most complicated one.

cmrd-senya commented 7 years ago

Also, here is my experimental branch with jQuery 3 support: https://github.com/cmrd-senya/jasmine-jquery/tree/jquery3

fiznool commented 7 years ago

Bumping this. Is there any plan to support jquery 3?