veliovgroup / Meteor-Files

🚀 Upload files via DDP or HTTP to ☄️ Meteor server FS, AWS, GridFS, DropBox or Google Drive. Fast, secure and robust.
https://packosphere.com/ostrio/files
BSD 3-Clause "New" or "Revised" License
1.11k stars 167 forks source link

Update aws-sdk to v3 in 'Use AWS:S3 As Storage' Documentation #874

Open ThaumRystra opened 1 year ago

ThaumRystra commented 1 year ago

In the documentation for using AWS:S3 As Storage, aws-sdk is at version 2.240.1, which now causes the following warning:

NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
dr-dimitru commented 1 year ago

@ThaumRystra would you love to send a PR?

ThaumRystra commented 1 year ago

I'm too dumb to get it to work right, so I am stuck on AWS 2.240 until I figure it out.

I'll submit a PR if I manage to get it working properly on AWS v3.

jacoatvatfree commented 6 months ago

Also note that trying to use AWS SDK v3 will throw a warning that Node 14 is no longer supported from 1 May 2024, so until meteor switches to a later Node version, there will be warnings.

dr-dimitru commented 5 months ago

@jacoatvatfree true, would like to submit a PR, at least as WIP, I will help to finalize, and I'm sure community would join too. Perhaps you have a project from where you can copy-paste general changes required for v3?

If you're going to submit a PR let's postfix files with v2 and v3 so we can reference S3 integrations in the docs for all of its versions