search

veliovgroup / Meteor-flow-router-title

Change document.title on the fly within flow-router
https://atmospherejs.com/ostrio/flow-router-title
BSD 3-Clause "New" or "Revised" License
25 stars 4 forks source link

Feature/setTimeout #11

Closed hakod closed 4 years ago

hakod commented 5 years ago

Thank you for contribution. Before you go:

  1. Make sure you're using spaces for indentation
  2. Make sure all new code is documented in-code-docs
  3. Make sure new features, or changes in behavior is documented in README.md and/or other docs materials
  4. Make sure this PR was previously discussed, if not create new issue ticket for your PR
  5. Give an expressive description what you have changed/added and why

Thank you for making this package better :)

Do not forget to get rid of this default message

dr-dimitru commented 5 years ago

Hey @hakod ,

We are definitely not going to use eval() in our code, but I'd like to understand why and how you come up with such idea? Could you please describe a use case?

hakod commented 5 years ago

Hi @dr-dimitru ,

Sorry, my mistake using eval(). The idea came while trying out the function with different methods. I thought setTimeout might provide smoother transition between routes instead of immediate updates. Maybe it could be used to update title at specific times during events too. Thanks for the feedback.

dr-dimitru commented 5 years ago

@hakod I don't see how it can be used in real life, or what issue does it solves? And what if I return function? Anyways thank you for attempt, going to try another one? Look at clientstorage package, there is open ticket for adding TTL (e.g. timeout) to persistent records, and another guy is failing it.