veliovgroup / flow-router

🚦 Carefully extended flow-router for Meteor
https://packosphere.com/ostrio/flow-router-extra
BSD 3-Clause "New" or "Revised" License
202 stars 29 forks source link

[METEOR@3.0-rc.0] Exception in setInterval callback #111

Closed ddaydd closed 5 months ago

ddaydd commented 5 months ago

I have this error in the console, am I the only one? have you already tried flow router with meteor 3?

Exception in setInterval callback: TypeError: subscription.ready is not a function at Route.checkSubscriptions

Edit : sorry, I have a package that prevents me from updating flow-router-extra and I don't know which one yet...

dr-dimitru commented 5 months ago

Hello @ddaydd, why it isn't planned?

ddaydd commented 5 months ago

sorry, I haven't managed to update the latest version of flow-router at the moment, and as I didn't know if the error was still relevant, I closed the topic...

dr-dimitru commented 5 months ago

@ddaydd do you mean it was solved after you upgraded?

ddaydd commented 5 months ago

no, I didn't manage to update, I don't know why a package is blocking me from updating and even by doing a meteor list -tree I can't find what this package is...

dr-dimitru commented 5 months ago

let me know if I can help

ddaydd commented 5 months ago

thanks, I will try to update first, to be continued :)

ddaydd commented 5 months ago

did you manage to install flow router on the latest version of METEOR@3.0-rc.0 with blaze ? I have these errors on a new application

=> Errors prevented startup:

While selecting package versions: error: Conflict: Constraint typescript@4.9.5-beta300.0 is not satisfied by typescript 5.4.3-rc300.0. Constraints on package "typescript":

ddaydd commented 5 months ago

Hi, it's works.

I changed api.versionsFrom(['1.4', '3.0-beta.0']); by api.versionsFrom(['3.0-rc.0']); and the latest version does not have the subscription bug

Thank you for motivating me to go further :)

dr-dimitru commented 5 months ago

@ddaydd

I changed api.versionsFrom(['1.4', '3.0-beta.0']); by api.versionsFrom(['3.0-rc.0']);

Changed in what package?

ddaydd commented 5 months ago

in ostrio:flow-router-extra that I downloaded :-p

acemtp commented 4 months ago

I had to clone the package just to add "3.0-rc.0" in a file.

Why this change is not in the main branch and the package released to be compatible with meteor 3?

dr-dimitru commented 4 months ago

@acemtp would you try v3.11.0-rc300.1 it should definitely work. What version have you installed?

acemtp commented 4 months ago

Damned, it was not in the release https://github.com/veliovgroup/flow-router/releases

I didn't know this version existed, thanks, I'll use it!

dr-dimitru commented 4 months ago

@acemtp it's pre-release, so I don't log it