search

veliovgroup / flow-router

🚦 Carefully extended flow-router for Meteor
https://packosphere.com/ostrio/flow-router-extra
BSD 3-Clause "New" or "Revised" License
201 stars 30 forks source link

Uncouple Blaze #33

Closed dr-dimitru closed 6 years ago

dr-dimitru commented 6 years ago

Uncouple Blaze by moving BlazeRenderer into separate package.

See this thread

derwaldgeist commented 6 years ago

Thanks for opening this! I think this is a major step forward to FlowRouter extra's general acceptance. One question related to this: Is it possible to use FlowRouter extra (as it is now) in combination with the old "BlazeLayout" package? I saw that FlowRouter extra has its own render() method, but this would mean refactoring all existing (old-FlowRouter) routes.

derwaldgeist commented 6 years ago

Just found this: https://github.com/VeliovGroup/flow-router/issues/32#issuecomment-343578907 which answers my question.

dr-dimitru commented 6 years ago

Yes, it will work, and we even test it for every release. Built-in . render() has it's own features for heavily animated websites, where FPS matters.

dr-dimitru commented 6 years ago

@derwaldgeist @krishaamer this request is implemented, and published as v3.4.4.

Feel free to contribute into React usage docs.

Please confirm v3.4.4 works smoothly on your end.

eleventy commented 6 years ago

Just updated tot 3.4.5, everything is running smoothly ( React only app ), and finally my last dependency on jquery disappeared. All the following packages are gone:

blaze                     removed from your project
bundle-visualizer         removed from your project
jquery                    removed from your project
observe-sequence          removed from your project
ostrio:flow-router-extra  upgraded from 3.4.3 to 3.4.5
spacebars                 removed from your project
templating                removed from your project
templating-compiler       removed from your project
templating-runtime        removed from your project

Nice work!

dr-dimitru commented 6 years ago

@eleventy awesome, thank you for feedback!