search

veliovgroup / flow-router

🚦 Carefully extended flow-router for Meteor
https://packosphere.com/ostrio/flow-router-extra
BSD 3-Clause "New" or "Revised" License
202 stars 29 forks source link

Duplicate template name in boilerplate template docs #38

Closed davidrea closed 6 years ago

davidrea commented 6 years ago

If the code and HTML provided in the templating guide are used verbatim, Meteor complains (in console) about duplicate templates named "index".

The "loading" template re-uses the template name "index":

<!-- /imports/client/loading/loading.html -->
<template name="index">
  Loading...
</template>
mikhail-shishov commented 6 years ago

Hello @davidrea ,

Let us know more details regarding this issue, please. Make sure you follow our issue template when describing the problem.

davidrea commented 6 years ago

From issue template:

Documentation is missing something or incorrect (have typos, etc.):

  • Give an expressive description what you have changed/added and why
  • Make sure you're using correct markdown markup
  • Make sure all code blocks starts with tripple ``` (backtick) and have a syntax tag, for more read this docs
  • Post your addition/changes in issue, we will manage it

Expressive description: ✔ Markdown markup correct: ✔ Code blocks triple-backticked with syntax tag: ✔ Change posted in issue: ✔

All that needs to be changed is <template name="index"> to <template name="loading"> in flow-router/docs/templating.md in the "Create Loading Template" section. See pull request.

dr-dimitru commented 6 years ago

@davidrea thank you for sending a PR, and spotting this dummy mistake. @mksh-su this is documentation erratum, solved with #39 PR.