search

veliovgroup / flow-router

🚦 Carefully extended flow-router for Meteor
https://packosphere.com/ostrio/flow-router-extra
BSD 3-Clause "New" or "Revised" License
202 stars 29 forks source link

Fast-render doesn't work #47

Closed dhamaniasad closed 6 years ago

dhamaniasad commented 6 years ago

I have a suggestion:

It seems like fast-rendering does not work with flow-router extra. The staringatlights:flow-router package has some code around this that makes the fast rendering work with staringatlights:fast-render. Here's a link to the code: https://github.com/abecks/flow-router/blob/master/server/plugins/fast_render.js

janat08 commented 6 years ago

Basically just copy and pasting the file hasn't worked.

dr-dimitru commented 6 years ago

Hello @dhamaniasad @janat08 ,

Does it work if you use 8-40 lines?

janat08 commented 6 years ago

I forgot to import flow-router instance into fast_render.js (and some other stuff), it works with all of the lines. When will you publish?

dhamaniasad commented 6 years ago

@dr-dimitru I copy pasted the entire file into my /lib folder, but the first few lines are just checking if the package is installed, the code should function without it just fine.

dr-dimitru commented 6 years ago

Thank you guys @dhamaniasad @janat08 ,

Published as v3.5.0. Let me know how it works for you.

dr-dimitru commented 6 years ago

Feel free to reopen it in case if the issue is still persists on your end.