allow to disable automatic link detection

[macrozone]

I moving that over from the original flow router repo:

https://github.com/kadirahq/flow-router/issues/705

I try to update to this version here, but my monkey patch from the original flow router no longer works, because _page is now hidden behind a getter :-(

So we need to adjust that in the initialisation code.

Maybe i can do a PR for that

[dr-dimitru]

Hello @macrozone ,

Do you wish to make _page static on FlowRouter object?

[dr-dimitru]

@macrozone or we can even add an option to disable binding for click event. Do you have thoughts for PR?

[macrozone]

@dr-dimitru, yes, I would do the following:

• Introduce function FlowRouter.disableLinkDetection()
• if called (before initialize), it will set click: false in https://github.com/VeliovGroup/flow-router/blob/master/client/router.js#L445 (default to true)

will try that out know

EDIT: its probably better to pass it as option to initialize:

initialize({disableLinkDetection: true})

[dr-dimitru]

@macrozone I believe it should be initialize option

[dr-dimitru]

Like:

FlowRouter.wait();
WhenEverYourAppIsReady(() => {
  FlowRouter.initialize({
    page: {
      click: false
    }
  });
});

[dr-dimitru]

@macrozone we can even allow this way to pass other options to page package

[macrozone]

@dr-dimitru there aren't that much options in page.js and one is already in options: hashbang. I don't think there are much more options that we ever want to pass to page.js ;-)

page.js is an implementation detail anyway.

But i will try out if it works for me and then we can decide how the option should look like, both variants are ok for me

[dr-dimitru]

@macrozone thank you a lot for contribution. Going to test on my end and publish later tonight

[dr-dimitru]

@macrozone just realized there was a way to access ._page:

import { Router } from 'meteor/ostrio:flow-router-extra';
Router.prototype._page; // <---

Added full list of exported classes and instances.

[macrozone]

@dr-dimitru good to know, but i am glad that we have now a clean solution for that specific problem that does not rely on monkey-patching ;-)

[dr-dimitru]

@macrozone thank you a lot for contribution. Sorry for delay with publishing, had to finish accumulated tasks 😬

Published as v3.5.1 Feel free to reopen it in case if the issue is still persists on your end.