search

veliovgroup / flow-router

🚦 Carefully extended flow-router for Meteor
https://packosphere.com/ostrio/flow-router-extra
BSD 3-Clause "New" or "Revised" License
201 stars 30 forks source link

Update page to 1.11.5 #75

Open jankapunkt opened 4 years ago

jankapunkt commented 4 years ago

NOTE: this is a work in progress PR attempting to fix #74 , since there are multiple issues to address. Not all issues may have been detected yet and regression needs to be tested as well.

Currently detected issues:

This isse is fixed by always transforming the path to a /name pattern. I am not 100% if the page package now won't accept other path variations as base anymore or has a bug or something.

This is fixed by setting the dispatch option in the page(options) call to false. This fixes the Client - Router - base path tests. However, there is no regression-test added yet.

We first need to find out, why the exit trigger is fired twice now, while before once

dr-dimitru commented 2 years ago

@jankapunkt do you want to try update page on the latest release? I have couple of things fixed

jankapunkt commented 1 month ago

@dr-dimitru does it make sense to continue this one, since Meteor3 upgrade is breaking anyway?

jankapunkt commented 1 month ago

@dr-dimitru also, it looks like page is abandoned and people look for a fork.

dr-dimitru commented 1 month ago

@jankapunkt I'll jump on full rewrite sometimes soon, dropping all dependencies. We can close this one for now.

Latest release works with meteor@3 as expected, right?

jankapunkt commented 1 month ago

@dr-dimitru it does not support Blaze 3, which is why I commented on #113 to include it