veliovgroup / jazeee-meteor-spiderable

Fork of Meteor Spiderable with longer timeout, caching, better server handling
https://atmospherejs.com/jazeee/spiderable-longer-timeout
33 stars 9 forks source link

v1.2.10 #21

Closed dr-dimitru closed 9 years ago

dr-dimitru commented 9 years ago
dr-dimitru commented 9 years ago

Hi @enricofoschi and @jazeee , could you test this PR on your end? Somehow it became 5x faster.

enricofoschi commented 9 years ago

Great improvements, will test as soon as I get a chance :+1:

enricofoschi commented 9 years ago

Fine by me. Unfortunately I didn't see any performance improvements on https://4scotty.com - although I had to change the package version of mongo@1.1.2 to mongo@1.1.1 as some other packages (e.g. reactivedict, ...) were not compatible with 1.1.2.

As I noticed also on github.com/meteor/meteor, mongo 1.1.2 is just a version bump without real changes. Am I wrong?

dr-dimitru commented 9 years ago

@enricofoschi not sure about real changes, but as you told to me before - it is a good behaviour to keep packages at latest version

dr-dimitru commented 9 years ago

@jazeee will you merge it?

dr-dimitru commented 9 years ago

@enricofoschi

although I had to change the package version of mongo@1.1.2 to mongo@1.1.1 as some other packages (e.g. reactivedict, ...) were not compatible with 1.1.2.

But every package use theirs own dependency version, so in one app always can be two packages depends from another one but of different versions - this is how it supposed to work.

dr-dimitru commented 9 years ago

@enricofoschi I think I've found source of empty pages issue - https://github.com/dr-dimitru/jazeee-meteor-spiderable/commit/64d0b9f39ef5d1bc2a290a10dcca162f1add9d72

jazeee commented 9 years ago

I've been traveling lately. I'll check and merge this change over the next day or so. On Oct 4, 2015 5:23 PM, "dr.dimitru" notifications@github.com wrote:

@enricofoschi https://github.com/enricofoschi I think I've found source of empty pages issue - dr-dimitru@64d0b9f https://github.com/dr-dimitru/jazeee-meteor-spiderable/commit/64d0b9f39ef5d1bc2a290a10dcca162f1add9d72

— Reply to this email directly or view it on GitHub https://github.com/jazeee/jazeee-meteor-spiderable/pull/21#issuecomment-145393628 .

dr-dimitru commented 9 years ago

Oh, okay. Hope you have had a nice trip :) Thank you for reply.

dr-dimitru commented 9 years ago

@jazeee

dr-dimitru commented 9 years ago

@jazeee Let me know how it is running on your end, ( @enricofoschi I believe now you should see some performance enhancement )

enricofoschi commented 9 years ago

Thanks dimitru - I'll run as soon as I get a chance.

On Mon, Oct 5, 2015 at 11:11 PM, dr.dimitru notifications@github.com wrote:

@jazeee https://github.com/jazeee Let me know how it is running on your end, ( @enricofoschi https://github.com/enricofoschi I believe now you should see some performance enhancement )

— Reply to this email directly or view it on GitHub https://github.com/jazeee/jazeee-meteor-spiderable/pull/21#issuecomment-145669627 .

Enrico Foschi

jazeee commented 9 years ago

Everything seems fine to me now.

dr-dimitru commented 9 years ago

Will you publish to atmosphere?

jazeee commented 9 years ago

Published.