Closed dr-dimitru closed 7 years ago
Hi @jazeee ,
I put some of my background work around phantomjs and meteor eco-system into this PR.
As you may see examples
is removed from this PR. Turned out everything inside package directory is published to atmosphere, and every developer used this package downloads examples
folder. Moreover examples
will be build-in into theirs production apps.
I'm suggesting to create separate repository for examples, or even deprecate it.
Let me know what do you think, and if it looks good to you, merge and meteor publish
Hi @jazeee ,
Any news on this one?
Hi there, I am in the middle of moving across the US, and new job. I don't know how much I can help here. Ideally, we can transfer this to @dr-dimitru for ownership. The Meteor package would be better owned by you too, but I haven't had time to look at how to do that. If you have some info on this, I can look at doing the transfer. Sorry about that.
Let me know and I'll go ahead and merge, but I haven't really reviewed the changes. I'll have to assume that @dr-dimitru is comfortable with the changes. I'll then publish to Meteor to at least get it out there.
It couldn't hurt to have someone else review it if possible. I just am too overloaded...
Hi @jazeee ,
Congrats on new position. Sure it's ready to be merged and published.
+1 for transferring package ownership to me. You can try to add me as maintainer, some info here - http://stackoverflow.com/questions/29267399/how-to-add-collaborator-for-meteor-package-in-atmosphere
What is your Meteor Id?
On Wed, Mar 1, 2017 at 11:59 AM, dr.dimitru notifications@github.com wrote:
Hi @jazeee https://github.com/jazeee ,
Congrats on new position. Sure it's ready to be merged and published.
+1 for transferring package ownership to me. You can try to add me as maintainer, some info here - http://stackoverflow.com/questions/29267399/how-to-add- collaborator-for-meteor-package-in-atmosphere
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jazeee/jazeee-meteor-spiderable/pull/44#issuecomment-283418302, or mute the thread https://github.com/notifications/unsubscribe-auth/AFXnaFC6DHOixBSOo-3_wLF4NMlTdFo1ks5rhbIJgaJpZM4MCi7I .
I've created cachedspiderable organization. I believe I have added you (drdimitru)
Now, need to transfer the package into that.
On Wed, Mar 1, 2017 at 12:07 PM, Jaz jazeee@gmail.com wrote:
What is your Meteor Id?
On Wed, Mar 1, 2017 at 11:59 AM, dr.dimitru notifications@github.com wrote:
Hi @jazeee https://github.com/jazeee ,
Congrats on new position. Sure it's ready to be merged and published.
+1 for transferring package ownership to me. You can try to add me as maintainer, some info here - http://stackoverflow.com/questions/29267399/how-to-add-colla borator-for-meteor-package-in-atmosphere
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jazeee/jazeee-meteor-spiderable/pull/44#issuecomment-283418302, or mute the thread https://github.com/notifications/unsubscribe-auth/AFXnaFC6DHOixBSOo-3_wLF4NMlTdFo1ks5rhbIJgaJpZM4MCi7I .
Yes, I was added to cachedspiderable.
But package still published under your name. So, I believe it's better to add me as collaborator to existing package, otherwise we have to re-publish it under new name, which will be: cachedspiderable:spiderable-longer-timeout
Ahh, yes, that is what I needed to do. You are now a maintainer.
On Wed, Mar 1, 2017 at 12:25 PM, dr.dimitru notifications@github.com wrote:
Yes, I was added to cachedspiderable.
But package still published under your name. So, I believe it's better to add me as collaborator to existing package, otherwise we have to re-publish to under new name, which will be: cachedspiderable:spiderable- longer-timeout
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jazeee/jazeee-meteor-spiderable/pull/44#issuecomment-283425407, or mute the thread https://github.com/notifications/unsubscribe-auth/AFXnaEOTcncSIfwu2xayqzaIlxZPN017ks5rhbf-gaJpZM4MCi7I .
Feel free to take over. @drdimitru You are probably the best maintainer/owner for this project now. Thanks for everything. Jaz.
On Wed, Mar 1, 2017 at 1:35 PM, Jaz jazeee@gmail.com wrote:
Ahh, yes, that is what I needed to do. You are now a maintainer.
On Wed, Mar 1, 2017 at 12:25 PM, dr.dimitru notifications@github.com wrote:
Yes, I was added to cachedspiderable.
But package still published under your name. So, I believe it's better to add me as collaborator to existing package, otherwise we have to re-publish to under new name, which will be: cachedspiderable:spiderable-lo nger-timeout
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jazeee/jazeee-meteor-spiderable/pull/44#issuecomment-283425407, or mute the thread https://github.com/notifications/unsubscribe-auth/AFXnaEOTcncSIfwu2xayqzaIlxZPN017ks5rhbf-gaJpZM4MCi7I .
Thank you Jaz
import
statement